summaryrefslogtreecommitdiffstats
path: root/Bugzilla/Status.pm
diff options
context:
space:
mode:
Diffstat (limited to 'Bugzilla/Status.pm')
-rw-r--r--Bugzilla/Status.pm254
1 files changed, 131 insertions, 123 deletions
diff --git a/Bugzilla/Status.pm b/Bugzilla/Status.pm
index ae04873a8..619594f5b 100644
--- a/Bugzilla/Status.pm
+++ b/Bugzilla/Status.pm
@@ -17,11 +17,11 @@ use warnings;
# methods.
use base qw(Bugzilla::Field::Choice Exporter);
@Bugzilla::Status::EXPORT = qw(
- BUG_STATE_OPEN
- SPECIAL_STATUS_WORKFLOW_ACTIONS
+ BUG_STATE_OPEN
+ SPECIAL_STATUS_WORKFLOW_ACTIONS
- is_open_state
- closed_bug_statuses
+ is_open_state
+ closed_bug_statuses
);
use Bugzilla::Error;
@@ -31,25 +31,25 @@ use Bugzilla::Error;
################################
use constant SPECIAL_STATUS_WORKFLOW_ACTIONS => qw(
- none
- duplicate
- change_resolution
- clearresolution
+ none
+ duplicate
+ change_resolution
+ clearresolution
);
use constant DB_TABLE => 'bug_status';
# This has all the standard Bugzilla::Field::Choice columns plus "is_open"
sub DB_COLUMNS {
- return ($_[0]->SUPER::DB_COLUMNS, 'is_open');
+ return ($_[0]->SUPER::DB_COLUMNS, 'is_open');
}
sub VALIDATORS {
- my $invocant = shift;
- my $validators = $invocant->SUPER::VALIDATORS;
- $validators->{is_open} = \&Bugzilla::Object::check_boolean;
- $validators->{value} = \&_check_value;
- return $validators;
+ my $invocant = shift;
+ my $validators = $invocant->SUPER::VALIDATORS;
+ $validators->{is_open} = \&Bugzilla::Object::check_boolean;
+ $validators->{value} = \&_check_value;
+ return $validators;
}
#########################
@@ -57,24 +57,25 @@ sub VALIDATORS {
#########################
sub create {
- my $class = shift;
- my $self = $class->SUPER::create(@_);
- delete Bugzilla->request_cache->{status_bug_state_open};
- add_missing_bug_status_transitions();
- return $self;
+ my $class = shift;
+ my $self = $class->SUPER::create(@_);
+ delete Bugzilla->request_cache->{status_bug_state_open};
+ add_missing_bug_status_transitions();
+ return $self;
}
sub remove_from_db {
- my $self = shift;
- my $dbh = Bugzilla->dbh;
- my $id = $self->id;
- $dbh->bz_start_transaction();
- $self->SUPER::remove_from_db();
- $dbh->do('DELETE FROM status_workflow
- WHERE old_status = ? OR new_status = ?',
- undef, $id, $id);
- $dbh->bz_commit_transaction();
- delete Bugzilla->request_cache->{status_bug_state_open};
+ my $self = shift;
+ my $dbh = Bugzilla->dbh;
+ my $id = $self->id;
+ $dbh->bz_start_transaction();
+ $self->SUPER::remove_from_db();
+ $dbh->do(
+ 'DELETE FROM status_workflow
+ WHERE old_status = ? OR new_status = ?', undef, $id, $id
+ );
+ $dbh->bz_commit_transaction();
+ delete Bugzilla->request_cache->{status_bug_state_open};
}
###############################
@@ -82,16 +83,16 @@ sub remove_from_db {
###############################
sub is_active { return $_[0]->{'isactive'}; }
-sub is_open { return $_[0]->{'is_open'}; }
+sub is_open { return $_[0]->{'is_open'}; }
sub is_static {
- my $self = shift;
- if ($self->name eq 'UNCONFIRMED'
- || $self->name eq Bugzilla->params->{'duplicate_or_move_bug_status'})
- {
- return 1;
- }
- return 0;
+ my $self = shift;
+ if ( $self->name eq 'UNCONFIRMED'
+ || $self->name eq Bugzilla->params->{'duplicate_or_move_bug_status'})
+ {
+ return 1;
+ }
+ return 0;
}
##############
@@ -99,14 +100,14 @@ sub is_static {
##############
sub _check_value {
- my $invocant = shift;
- my $value = $invocant->SUPER::_check_value(@_);
-
- if (grep { lc($value) eq lc($_) } SPECIAL_STATUS_WORKFLOW_ACTIONS) {
- ThrowUserError('fieldvalue_reserved_word',
- { field => $invocant->field, value => $value });
- }
- return $value;
+ my $invocant = shift;
+ my $value = $invocant->SUPER::_check_value(@_);
+
+ if (grep { lc($value) eq lc($_) } SPECIAL_STATUS_WORKFLOW_ACTIONS) {
+ ThrowUserError('fieldvalue_reserved_word',
+ {field => $invocant->field, value => $value});
+ }
+ return $value;
}
@@ -115,118 +116,125 @@ sub _check_value {
###############################
sub BUG_STATE_OPEN {
- my $dbh = Bugzilla->dbh;
- my $request_cache = Bugzilla->request_cache;
- my $cache_key = 'status_bug_state_open';
- return @{ $request_cache->{$cache_key} }
- if exists $request_cache->{$cache_key};
-
- my $rows = Bugzilla->memcached->get_config({ key => $cache_key });
- if (!$rows) {
- $rows = $dbh->selectcol_arrayref(
- 'SELECT value FROM bug_status WHERE is_open = 1'
- );
- Bugzilla->memcached->set_config({ key => $cache_key, data => $rows });
- }
-
- $request_cache->{$cache_key} = $rows;
- return @$rows;
+ my $dbh = Bugzilla->dbh;
+ my $request_cache = Bugzilla->request_cache;
+ my $cache_key = 'status_bug_state_open';
+ return @{$request_cache->{$cache_key}} if exists $request_cache->{$cache_key};
+
+ my $rows = Bugzilla->memcached->get_config({key => $cache_key});
+ if (!$rows) {
+ $rows
+ = $dbh->selectcol_arrayref('SELECT value FROM bug_status WHERE is_open = 1');
+ Bugzilla->memcached->set_config({key => $cache_key, data => $rows});
+ }
+
+ $request_cache->{$cache_key} = $rows;
+ return @$rows;
}
# Tells you whether or not the argument is a valid "open" state.
sub is_open_state {
- my ($state) = @_;
- return (grep($_ eq $state, BUG_STATE_OPEN) ? 1 : 0);
+ my ($state) = @_;
+ return (grep($_ eq $state, BUG_STATE_OPEN) ? 1 : 0);
}
sub closed_bug_statuses {
- my @bug_statuses = Bugzilla::Status->get_all;
- @bug_statuses = grep { !$_->is_open } @bug_statuses;
- return @bug_statuses;
+ my @bug_statuses = Bugzilla::Status->get_all;
+ @bug_statuses = grep { !$_->is_open } @bug_statuses;
+ return @bug_statuses;
}
sub can_change_to {
- my $self = shift;
- my $dbh = Bugzilla->dbh;
-
- if (!ref($self) || !defined $self->{'can_change_to'}) {
- my ($cond, @args, $self_exists);
- if (ref($self)) {
- $cond = '= ?';
- push(@args, $self->id);
- $self_exists = 1;
- }
- else {
- $cond = 'IS NULL';
- # Let's do it so that the code below works in all cases.
- $self = {};
- }
-
- my $new_status_ids = $dbh->selectcol_arrayref("SELECT new_status
+ my $self = shift;
+ my $dbh = Bugzilla->dbh;
+
+ if (!ref($self) || !defined $self->{'can_change_to'}) {
+ my ($cond, @args, $self_exists);
+ if (ref($self)) {
+ $cond = '= ?';
+ push(@args, $self->id);
+ $self_exists = 1;
+ }
+ else {
+ $cond = 'IS NULL';
+
+ # Let's do it so that the code below works in all cases.
+ $self = {};
+ }
+
+ my $new_status_ids = $dbh->selectcol_arrayref(
+ "SELECT new_status
FROM status_workflow
INNER JOIN bug_status
ON id = new_status
WHERE isactive = 1
AND old_status $cond
- ORDER BY sortkey",
- undef, @args);
+ ORDER BY sortkey", undef, @args
+ );
- # Allow the bug status to remain unchanged.
- push(@$new_status_ids, $self->id) if $self_exists;
- $self->{'can_change_to'} = Bugzilla::Status->new_from_list($new_status_ids);
- }
+ # Allow the bug status to remain unchanged.
+ push(@$new_status_ids, $self->id) if $self_exists;
+ $self->{'can_change_to'} = Bugzilla::Status->new_from_list($new_status_ids);
+ }
- return $self->{'can_change_to'};
+ return $self->{'can_change_to'};
}
sub comment_required_on_change_from {
- my ($self, $old_status) = @_;
- my ($cond, $values) = $self->_status_condition($old_status);
-
- my ($require_comment) = Bugzilla->dbh->selectrow_array(
- "SELECT require_comment FROM status_workflow
- WHERE $cond", undef, @$values);
- return $require_comment;
+ my ($self, $old_status) = @_;
+ my ($cond, $values) = $self->_status_condition($old_status);
+
+ my ($require_comment) = Bugzilla->dbh->selectrow_array(
+ "SELECT require_comment FROM status_workflow
+ WHERE $cond", undef, @$values
+ );
+ return $require_comment;
}
# Used as a helper for various functions that have to deal with old_status
# sometimes being NULL and sometimes having a value.
sub _status_condition {
- my ($self, $old_status) = @_;
- my @values;
- my $cond = 'old_status IS NULL';
- # For newly-filed bugs
- if ($old_status) {
- $cond = 'old_status = ?';
- push(@values, $old_status->id);
- }
- $cond .= " AND new_status = ?";
- push(@values, $self->id);
- return ($cond, \@values);
+ my ($self, $old_status) = @_;
+ my @values;
+ my $cond = 'old_status IS NULL';
+
+ # For newly-filed bugs
+ if ($old_status) {
+ $cond = 'old_status = ?';
+ push(@values, $old_status->id);
+ }
+ $cond .= " AND new_status = ?";
+ push(@values, $self->id);
+ return ($cond, \@values);
}
sub add_missing_bug_status_transitions {
- my $bug_status = shift || Bugzilla->params->{'duplicate_or_move_bug_status'};
- my $dbh = Bugzilla->dbh;
- my $new_status = new Bugzilla::Status({name => $bug_status});
- # Silently discard invalid bug statuses.
- $new_status || return;
+ my $bug_status = shift || Bugzilla->params->{'duplicate_or_move_bug_status'};
+ my $dbh = Bugzilla->dbh;
+ my $new_status = new Bugzilla::Status({name => $bug_status});
- my $missing_statuses = $dbh->selectcol_arrayref('SELECT id
+ # Silently discard invalid bug statuses.
+ $new_status || return;
+
+ my $missing_statuses = $dbh->selectcol_arrayref(
+ 'SELECT id
FROM bug_status
LEFT JOIN status_workflow
ON old_status = id
AND new_status = ?
WHERE old_status IS NULL',
- undef, $new_status->id);
-
- my $sth = $dbh->prepare('INSERT INTO status_workflow
- (old_status, new_status) VALUES (?, ?)');
-
- foreach my $old_status_id (@$missing_statuses) {
- next if ($old_status_id == $new_status->id);
- $sth->execute($old_status_id, $new_status->id);
- }
+ undef, $new_status->id
+ );
+
+ my $sth = $dbh->prepare(
+ 'INSERT INTO status_workflow
+ (old_status, new_status) VALUES (?, ?)'
+ );
+
+ foreach my $old_status_id (@$missing_statuses) {
+ next if ($old_status_id == $new_status->id);
+ $sth->execute($old_status_id, $new_status->id);
+ }
}
1;
generated by cgit v1.2.3-24-g4f1b (git 2.32.0) at 2024-05-03 05:56:40 +0200