diff options
Diffstat (limited to 'Bugzilla')
| -rw-r--r-- | Bugzilla/DB.pm | 5 | ||||
| -rw-r--r-- | Bugzilla/JobQueue.pm | 2 | ||||
| -rw-r--r-- | Bugzilla/WebService/Server/XMLRPC.pm | 6 |
3 files changed, 6 insertions, 7 deletions
diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm index a702a0f60..b8a638e24 100644 --- a/Bugzilla/DB.pm +++ b/Bugzilla/DB.pm @@ -271,8 +271,7 @@ EOT } # List of abstract methods we are checking the derived class implements -our @_abstract_methods = qw(REQUIRED_VERSION PROGRAM_NAME DBD_VERSION - new sql_regexp sql_not_regexp sql_limit sql_to_days +our @_abstract_methods = qw(new sql_regexp sql_not_regexp sql_limit sql_to_days sql_date_format sql_interval bz_explain sql_group_concat); @@ -287,7 +286,7 @@ sub import { # make sure all abstract methods are implemented foreach my $meth (@_abstract_methods) { $pkg->can($meth) - or croak("Class $pkg does not define method $meth"); + or die("Class $pkg does not define method $meth"); } } diff --git a/Bugzilla/JobQueue.pm b/Bugzilla/JobQueue.pm index d10df9804..9e7172e2b 100644 --- a/Bugzilla/JobQueue.pm +++ b/Bugzilla/JobQueue.pm @@ -27,7 +27,7 @@ use strict; use Bugzilla::Constants; use Bugzilla::Error; use Bugzilla::Install::Util qw(install_string); -BEGIN { eval "use base qw(TheSchwartz)"; } +use base qw(TheSchwartz); # This maps job names for Bugzilla::JobQueue to the appropriate modules. # If you add new types of jobs, you should add a mapping here. diff --git a/Bugzilla/WebService/Server/XMLRPC.pm b/Bugzilla/WebService/Server/XMLRPC.pm index cbfb1b7f2..967235262 100644 --- a/Bugzilla/WebService/Server/XMLRPC.pm +++ b/Bugzilla/WebService/Server/XMLRPC.pm @@ -64,7 +64,7 @@ package Bugzilla::XMLRPC::Deserializer; use strict; # We can't use "use base" because XMLRPC::Serializer doesn't return # a true value. -eval { require XMLRPC::Lite; }; +use XMLRPC::Lite; our @ISA = qw(XMLRPC::Deserializer); use Bugzilla::Error; @@ -141,7 +141,7 @@ sub _validation_subs { package Bugzilla::XMLRPC::SOM; use strict; -eval { require XMLRPC::Lite; }; +use XMLRPC::Lite; our @ISA = qw(XMLRPC::SOM); use Bugzilla::WebService::Util qw(taint_data); @@ -165,7 +165,7 @@ use Scalar::Util qw(blessed); use strict; # We can't use "use base" because XMLRPC::Serializer doesn't return # a true value. -eval { require XMLRPC::Lite; }; +use XMLRPC::Lite; our @ISA = qw(XMLRPC::Serializer); sub new { |