summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
Diffstat (limited to 'Bugzilla')
-rwxr-xr-xBugzilla/Bug.pm32
-rw-r--r--Bugzilla/BugMail.pm16
-rw-r--r--Bugzilla/Classification.pm4
-rw-r--r--Bugzilla/Component.pm2
-rw-r--r--Bugzilla/DB.pm6
-rw-r--r--Bugzilla/Field.pm4
-rw-r--r--Bugzilla/Group.pm4
-rw-r--r--Bugzilla/Milestone.pm6
-rw-r--r--Bugzilla/Product.pm6
-rw-r--r--Bugzilla/Template.pm2
-rw-r--r--Bugzilla/Token.pm6
-rw-r--r--Bugzilla/User.pm8
-rw-r--r--Bugzilla/Util.pm12
-rw-r--r--Bugzilla/Version.pm4
14 files changed, 56 insertions, 56 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index c7e763748..d20af1268 100755
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -339,7 +339,7 @@ sub actual_time {
return $self->{'actual_time'};
}
-sub any_flags_requesteeble () {
+sub any_flags_requesteeble {
my ($self) = @_;
return $self->{'any_flags_requesteeble'}
if exists $self->{'any_flags_requesteeble'};
@@ -351,7 +351,7 @@ sub any_flags_requesteeble () {
return $self->{'any_flags_requesteeble'};
}
-sub attachments () {
+sub attachments {
my ($self) = @_;
return $self->{'attachments'} if exists $self->{'attachments'};
return [] if $self->{'error'};
@@ -359,7 +359,7 @@ sub attachments () {
return $self->{'attachments'};
}
-sub assigned_to () {
+sub assigned_to {
my ($self) = @_;
return $self->{'assigned_to'} if exists $self->{'assigned_to'};
$self->{'assigned_to_id'} = 0 if $self->{'error'};
@@ -367,7 +367,7 @@ sub assigned_to () {
return $self->{'assigned_to'};
}
-sub blocked () {
+sub blocked {
my ($self) = @_;
return $self->{'blocked'} if exists $self->{'blocked'};
return [] if $self->{'error'};
@@ -378,7 +378,7 @@ sub blocked () {
# Even bugs in an error state always have a bug_id.
sub bug_id { $_[0]->{'bug_id'}; }
-sub cc () {
+sub cc {
my ($self) = @_;
return $self->{'cc'} if exists $self->{'cc'};
return [] if $self->{'error'};
@@ -396,7 +396,7 @@ sub cc () {
return $self->{'cc'};
}
-sub dependson () {
+sub dependson {
my ($self) = @_;
return $self->{'dependson'} if exists $self->{'dependson'};
return [] if $self->{'error'};
@@ -405,7 +405,7 @@ sub dependson () {
return $self->{'dependson'};
}
-sub flag_types () {
+sub flag_types {
my ($self) = @_;
return $self->{'flag_types'} if exists $self->{'flag_types'};
return [] if $self->{'error'};
@@ -430,7 +430,7 @@ sub flag_types () {
return $self->{'flag_types'};
}
-sub keywords () {
+sub keywords {
my ($self) = @_;
return $self->{'keywords'} if exists $self->{'keywords'};
return () if $self->{'error'};
@@ -456,7 +456,7 @@ sub longdescs {
return $self->{'longdescs'};
}
-sub milestoneurl () {
+sub milestoneurl {
my ($self) = @_;
return $self->{'milestoneurl'} if exists $self->{'milestoneurl'};
return '' if $self->{'error'};
@@ -464,7 +464,7 @@ sub milestoneurl () {
return $self->{'milestoneurl'};
}
-sub qa_contact () {
+sub qa_contact {
my ($self) = @_;
return $self->{'qa_contact'} if exists $self->{'qa_contact'};
return undef if $self->{'error'};
@@ -480,7 +480,7 @@ sub qa_contact () {
return $self->{'qa_contact'};
}
-sub reporter () {
+sub reporter {
my ($self) = @_;
return $self->{'reporter'} if exists $self->{'reporter'};
$self->{'reporter_id'} = 0 if $self->{'error'};
@@ -489,7 +489,7 @@ sub reporter () {
}
-sub show_attachment_flags () {
+sub show_attachment_flags {
my ($self) = @_;
return $self->{'show_attachment_flags'}
if exists $self->{'show_attachment_flags'};
@@ -694,7 +694,7 @@ sub choices {
# the alias.
# Queries the database for the bug with a given alias, and returns
# the ID of the bug if it exists or the undefined value if it doesn't.
-sub bug_alias_to_id ($) {
+sub bug_alias_to_id {
my ($alias) = @_;
return undef unless Param("usebugaliases");
my $dbh = Bugzilla->dbh;
@@ -707,7 +707,7 @@ sub bug_alias_to_id ($) {
# Subroutines
#####################################################################
-sub AppendComment ($$$;$$$) {
+sub AppendComment {
my ($bugid, $whoid, $comment, $isprivate, $timestamp, $work_time) = @_;
$work_time ||= 0;
my $dbh = Bugzilla->dbh;
@@ -992,7 +992,7 @@ sub CountOpenDependencies {
return @dependencies;
}
-sub ValidateComment ($) {
+sub ValidateComment {
my ($comment) = @_;
if (defined($comment) && length($comment) > MAX_COMMENT_LENGTH) {
@@ -1242,7 +1242,7 @@ sub ValidateBugAlias {
}
# Validate and return a hash of dependencies
-sub ValidateDependencies($$$) {
+sub ValidateDependencies {
my $fields = {};
$fields->{'dependson'} = shift;
$fields->{'blocked'} = shift;
diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm
index 6bbebfa7c..35026b48e 100644
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -112,7 +112,7 @@ END
# All the names are email addresses, not userids
# values are scalars, except for cc, which is a list
# This hash usually comes from the "mailrecipients" var in a template call.
-sub Send($;$) {
+sub Send {
my ($id, $forced) = (@_);
# This only works in a sub. Probably something to do with the
@@ -122,7 +122,7 @@ sub Send($;$) {
return ProcessOneBug($id, $forced);
}
-sub ProcessOneBug($$) {
+sub ProcessOneBug {
my ($id, $forced) = (@_);
my @headerlist;
@@ -474,7 +474,7 @@ sub ProcessOneBug($$) {
return {'sent' => \@sent, 'excluded' => \@excluded};
}
-sub sendMail($$$$$$$$$$$$) {
+sub sendMail {
my ($user, $hlRef, $relRef, $valueRef, $dmhRef, $fdRef,
$diffRef, $newcomments, $anyprivate, $start,
$id) = @_;
@@ -608,7 +608,7 @@ sub sendMail($$$$$$$$$$$$) {
return 1;
}
-sub MessageToMTA ($) {
+sub MessageToMTA {
my ($msg) = (@_);
return if (Param('mail_delivery_method') eq "none");
@@ -639,7 +639,7 @@ sub MessageToMTA ($) {
$mailer->close;
}
-sub encode_qp_words($) {
+sub encode_qp_words {
my ($line) = (@_);
my @encoded;
foreach my $word (split / /, $line) {
@@ -652,7 +652,7 @@ sub encode_qp_words($) {
return join(' ', @encoded);
}
-sub encode_message($$) {
+sub encode_message {
my ($header, $body) = @_;
# read header into MIME::Entity
@@ -735,14 +735,14 @@ sub encode_message($$) {
# its value will be placed into the string. If it's not a key in the hash,
# then the value of the parameter called "some_variable_name" will be placed
# into the string.
-sub PerformSubsts ($;$) {
+sub PerformSubsts {
my ($str, $substs) = (@_);
$str =~ s/%([a-z]*)%/(defined $substs->{$1} ? $substs->{$1} : Param($1))/eg;
return $str;
}
# Send the login name and password of the newly created account to the user.
-sub MailPassword ($$) {
+sub MailPassword {
my ($login, $password) = (@_);
my $template = Param("passwordmail");
my $msg = PerformSubsts($template,
diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm
index c35c0ba9b..4f50848a2 100644
--- a/Bugzilla/Classification.pm
+++ b/Bugzilla/Classification.pm
@@ -105,7 +105,7 @@ sub description { return $_[0]->{'description'}; }
#### Subroutines ####
###############################
-sub get_all_classifications () {
+sub get_all_classifications {
my $dbh = Bugzilla->dbh;
my $ids = $dbh->selectcol_arrayref(q{
@@ -118,7 +118,7 @@ sub get_all_classifications () {
return @classifications;
}
-sub check_classification ($) {
+sub check_classification {
my ($class_name) = @_;
unless ($class_name) {
diff --git a/Bugzilla/Component.pm b/Bugzilla/Component.pm
index 216616d98..f1d4c24b2 100644
--- a/Bugzilla/Component.pm
+++ b/Bugzilla/Component.pm
@@ -103,7 +103,7 @@ sub default_qa_contact { return $_[0]->{'initialqacontact'}; }
#### Subroutines ####
###############################
-sub get_components_by_product ($) {
+sub get_components_by_product {
my ($product_id) = @_;
my $dbh = Bugzilla->dbh;
diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index 43c14a551..67cf4ae9c 100644
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -128,12 +128,12 @@ sub FetchOneColumn {
return $row[0];
}
-sub PushGlobalSQLState() {
+sub PushGlobalSQLState {
push @SQLStateStack, $_current_sth;
push @SQLStateStack, $_fetchahead;
}
-sub PopGlobalSQLState() {
+sub PopGlobalSQLState {
die ("PopGlobalSQLState: stack underflow") if ( scalar(@SQLStateStack) < 1 );
$_fetchahead = pop @SQLStateStack;
$_current_sth = pop @SQLStateStack;
@@ -153,7 +153,7 @@ sub connect_shadow {
Param("shadowdbsock"), $db_user, $db_pass);
}
-sub connect_main (;$) {
+sub connect_main {
my ($no_db_name) = @_;
my $connect_to_db = $db_name;
$connect_to_db = "" if $no_db_name;
diff --git a/Bugzilla/Field.pm b/Bugzilla/Field.pm
index ed82f805b..37771257c 100644
--- a/Bugzilla/Field.pm
+++ b/Bugzilla/Field.pm
@@ -27,7 +27,7 @@ use Bugzilla::Util;
use Bugzilla::Error;
-sub check_form_field ($$;$) {
+sub check_form_field {
my ($cgi, $fieldname, $legalsRef) = @_;
my $dbh = Bugzilla->dbh;
@@ -45,7 +45,7 @@ sub check_form_field ($$;$) {
}
}
-sub check_form_field_defined ($$) {
+sub check_form_field_defined {
my ($cgi, $fieldname) = @_;
if (!defined $cgi->param($fieldname)) {
diff --git a/Bugzilla/Group.pm b/Bugzilla/Group.pm
index 808860274..e24ccb254 100644
--- a/Bugzilla/Group.pm
+++ b/Bugzilla/Group.pm
@@ -106,7 +106,7 @@ sub is_active { return $_[0]->{'isactive'}; }
##### Module Subroutines ###
################################
-sub ValidateGroupName ($$) {
+sub ValidateGroupName {
my ($name, @users) = (@_);
my $dbh = Bugzilla->dbh;
my $query = "SELECT id FROM groups " .
@@ -125,7 +125,7 @@ sub ValidateGroupName ($$) {
return $ret;
}
-sub get_group_controls_by_product ($) {
+sub get_group_controls_by_product {
my ($product_id) = @_;
my $dbh = Bugzilla->dbh;
diff --git a/Bugzilla/Milestone.pm b/Bugzilla/Milestone.pm
index 6956d5313..fa8fc0f82 100644
--- a/Bugzilla/Milestone.pm
+++ b/Bugzilla/Milestone.pm
@@ -99,7 +99,7 @@ sub sortkey { return $_[0]->{'sortkey'}; }
##### Subroutines #####
################################
-sub get_milestones_by_product ($) {
+sub get_milestones_by_product {
my ($product_id) = @_;
my $dbh = Bugzilla->dbh;
@@ -125,7 +125,7 @@ sub get_milestones_by_product ($) {
return @milestones;
}
-sub check_milestone ($$) {
+sub check_milestone {
my ($product, $milestone_name) = @_;
unless ($milestone_name) {
@@ -142,7 +142,7 @@ sub check_milestone ($$) {
return $milestone;
}
-sub check_sort_key ($$) {
+sub check_sort_key {
my ($milestone_name, $sortkey) = @_;
# Keep a copy in case detaint_signed() clears the sortkey
my $stored_sortkey = $sortkey;
diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index 26c80103f..7af2995c2 100644
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -178,7 +178,7 @@ sub classification_id { return $_[0]->{'classification_id'}; }
#### Subroutines ######
###############################
-sub get_products_by_classification ($) {
+sub get_products_by_classification {
my ($class_id) = @_;
my $dbh = Bugzilla->dbh;
$class_id ||= DEFAULT_CLASSIFICATION_ID;
@@ -205,7 +205,7 @@ sub get_products_by_classification ($) {
return @products;
}
-sub get_all_products () {
+sub get_all_products {
my $dbh = Bugzilla->dbh;
my $ids = $dbh->selectcol_arrayref(q{
@@ -218,7 +218,7 @@ sub get_all_products () {
return @products;
}
-sub check_product ($) {
+sub check_product {
my ($product_name) = @_;
unless ($product_name) {
diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm
index 5c5aff574..711144a6f 100644
--- a/Bugzilla/Template.pm
+++ b/Bugzilla/Template.pm
@@ -97,7 +97,7 @@ sub sortAcceptLanguage {
# Returns the path to the templates based on the Accept-Language
# settings of the user and of the available languages
# If no Accept-Language is present it uses the defined default
-sub getTemplateIncludePath () {
+sub getTemplateIncludePath {
# Return cached value if available
# XXXX - mod_perl!
diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm
index 44ee1a642..a198dda3f 100644
--- a/Bugzilla/Token.pm
+++ b/Bugzilla/Token.pm
@@ -249,7 +249,7 @@ sub HasEmailChangeToken {
return $token;
}
-sub GetTokenData($) {
+sub GetTokenData {
# Returns the userid, issuedate and eventdata for the specified token
my ($token) = @_;
@@ -263,7 +263,7 @@ sub GetTokenData($) {
WHERE token = ?", undef, $token);
}
-sub DeleteToken($) {
+sub DeleteToken {
# Deletes specified token
my ($token) = @_;
@@ -280,7 +280,7 @@ sub DeleteToken($) {
# Internal Functions
################################################################################
-sub _create_token($$$) {
+sub _create_token {
# Generates a unique token and inserts it into the database
# Returns the token and the token timestamp
my ($userid, $tokentype, $eventdata) = @_;
diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index f9efcd248..5462aa5d4 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -1156,7 +1156,7 @@ sub get_userlist {
return $self->{'userlist'};
}
-sub insert_new_user ($$;$$) {
+sub insert_new_user {
my ($username, $realname, $password, $disabledtext) = (@_);
my $dbh = Bugzilla->dbh;
@@ -1201,7 +1201,7 @@ sub insert_new_user ($$;$$) {
return $password;
}
-sub is_available_username ($;$) {
+sub is_available_username {
my ($username, $old_username) = @_;
if(login_to_id($username) != 0) {
@@ -1237,7 +1237,7 @@ sub is_available_username ($;$) {
return 1;
}
-sub login_to_id ($) {
+sub login_to_id {
my ($login) = (@_);
my $dbh = Bugzilla->dbh;
# $login will only be used by the following SELECT statement, so it's safe.
@@ -1252,7 +1252,7 @@ sub login_to_id ($) {
}
}
-sub UserInGroup ($) {
+sub UserInGroup {
return defined Bugzilla->user->groups->{$_[0]} ? 1 : 0;
}
diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm
index 43100b160..d70bc13dd 100644
--- a/Bugzilla/Util.pm
+++ b/Bugzilla/Util.pm
@@ -138,7 +138,7 @@ sub url_decode {
return $todecode;
}
-sub i_am_cgi () {
+sub i_am_cgi {
# I use SERVER_SOFTWARE because it's required to be
# defined for all requests in the CGI spec.
return exists $ENV{'SERVER_SOFTWARE'} ? 1 : 0;
@@ -221,7 +221,7 @@ sub diff_strings {
return ($removed, $added);
}
-sub wrap_comment ($) {
+sub wrap_comment {
my ($comment) = @_;
my $wrappedcomment = "";
@@ -245,7 +245,7 @@ sub wrap_comment ($) {
return $wrappedcomment;
}
-sub find_wrap_point ($$) {
+sub find_wrap_point {
my ($string, $maxpos) = @_;
if (!$string) { return 0 }
if (length($string) < $maxpos) { return length($string) }
@@ -264,7 +264,7 @@ sub find_wrap_point ($$) {
return $wrappoint;
}
-sub format_time ($;$) {
+sub format_time {
my ($date, $format) = @_;
# If $format is undefined, try to guess the correct date format.
@@ -316,7 +316,7 @@ sub format_time_decimal {
return $newtime;
}
-sub file_mod_time ($) {
+sub file_mod_time {
my ($filename) = (@_);
my ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size,
$atime,$mtime,$ctime,$blksize,$blocks)
@@ -324,7 +324,7 @@ sub file_mod_time ($) {
return $mtime;
}
-sub bz_crypt ($) {
+sub bz_crypt {
my ($password) = @_;
# The list of characters that can appear in a salt. Salts and hashes
diff --git a/Bugzilla/Version.pm b/Bugzilla/Version.pm
index 3a460e028..473a186c2 100644
--- a/Bugzilla/Version.pm
+++ b/Bugzilla/Version.pm
@@ -97,7 +97,7 @@ sub product_id { return $_[0]->{'product_id'}; }
##### Subroutines ###
###############################
-sub get_versions_by_product ($) {
+sub get_versions_by_product {
my ($product_id) = @_;
my $dbh = Bugzilla->dbh;
@@ -123,7 +123,7 @@ sub get_versions_by_product ($) {
return @versions;
}
-sub check_version ($$) {
+sub check_version {
my ($product, $version_name) = @_;
$version_name || ThrowUserError('version_not_specified');
generated by cgit v1.2.3-24-g4f1b (git 2.32.0) at 2024-11-22 22:16:20 +0100