summaryrefslogtreecommitdiffstats
path: root/extensions/MozProjectReview/Extension.pm
diff options
context:
space:
mode:
Diffstat (limited to 'extensions/MozProjectReview/Extension.pm')
-rw-r--r--extensions/MozProjectReview/Extension.pm254
1 files changed, 133 insertions, 121 deletions
diff --git a/extensions/MozProjectReview/Extension.pm b/extensions/MozProjectReview/Extension.pm
index 29d709ff4..c5cd27d21 100644
--- a/extensions/MozProjectReview/Extension.pm
+++ b/extensions/MozProjectReview/Extension.pm
@@ -22,139 +22,151 @@ use Bugzilla::Constants;
use List::MoreUtils qw(any);
sub post_bug_after_creation {
- my ($self, $args) = @_;
- my $vars = $args->{'vars'};
- my $bug = $vars->{'bug'};
- my $timestamp = $args->{'timestamp'};
- my $user = Bugzilla->user;
- my $params = Bugzilla->input_params;
- my $template = Bugzilla->template;
-
- return if !($params->{format} && $params->{format} eq 'moz-project-review');
-
- # do a match if applicable
- Bugzilla::User::match_field({
- 'sow_vendor_mozcontact' => { 'type' => 'single' },
- });
-
- my $do_sec_review = 0;
- my @sec_review_needed = (
- 'Engaging a new vendor company',
- 'Adding a new SOW with a vendor',
- 'Extending a SOW or renewing a contract',
- 'Purchasing software',
- 'Signing up for an online service',
- 'Other'
- );
- if ((any { $_ eq $params->{contract_type} } @sec_review_needed)
- || $params->{mozilla_data} eq 'Yes') {
- $do_sec_review = 1;
- }
-
- my ($sec_review_bug, $finance_bug, $error, @dep_comment, @dep_errors, @send_mail);
-
- # Common parameters always passed to _file_child_bug
- # bug_data and template_suffix will be different for each bug
- my $child_params = {
- parent_bug => $bug,
- template_vars => $vars,
- dep_comment => \@dep_comment,
- dep_errors => \@dep_errors,
- send_mail => \@send_mail,
- };
-
- if ($do_sec_review) {
- $child_params->{'bug_data'} = {
- short_desc => 'RRA: ' . $params->{contract_type} . ' with ' . $params->{other_party},
- product => 'Enterprise Information Security',
- component => 'Rapid Risk Analysis',
- bug_severity => 'normal',
- groups => [ 'mozilla-employee-confidential' ],
- op_sys => 'All',
- rep_platform => 'All',
- version => 'unspecified',
- blocked => $bug->bug_id,
- cc => $params->{cc},
- };
- $child_params->{'template_suffix'} = 'sec-review';
- _file_child_bug($child_params);
- }
-
+ my ($self, $args) = @_;
+ my $vars = $args->{'vars'};
+ my $bug = $vars->{'bug'};
+ my $timestamp = $args->{'timestamp'};
+ my $user = Bugzilla->user;
+ my $params = Bugzilla->input_params;
+ my $template = Bugzilla->template;
+
+ return if !($params->{format} && $params->{format} eq 'moz-project-review');
+
+ # do a match if applicable
+ Bugzilla::User::match_field({'sow_vendor_mozcontact' => {'type' => 'single'},});
+
+ my $do_sec_review = 0;
+ my @sec_review_needed = (
+ 'Engaging a new vendor company',
+ 'Adding a new SOW with a vendor',
+ 'Extending a SOW or renewing a contract',
+ 'Purchasing software',
+ 'Signing up for an online service',
+ 'Other'
+ );
+ if ((any { $_ eq $params->{contract_type} } @sec_review_needed)
+ || $params->{mozilla_data} eq 'Yes')
+ {
+ $do_sec_review = 1;
+ }
+
+ my ($sec_review_bug, $finance_bug, $error, @dep_comment, @dep_errors,
+ @send_mail);
+
+ # Common parameters always passed to _file_child_bug
+ # bug_data and template_suffix will be different for each bug
+ my $child_params = {
+ parent_bug => $bug,
+ template_vars => $vars,
+ dep_comment => \@dep_comment,
+ dep_errors => \@dep_errors,
+ send_mail => \@send_mail,
+ };
+
+ if ($do_sec_review) {
$child_params->{'bug_data'} = {
- short_desc => 'Finance Review: ' . $params->{contract_type} . ' with ' . $params->{other_party},
- product => 'Finance',
- component => 'Purchase Request Form',
- bug_severity => 'normal',
- priority => '--',
- groups => [ 'finance' ],
- op_sys => 'All',
- rep_platform => 'All',
- version => 'unspecified',
- blocked => $bug->bug_id,
- cc => $params->{cc},
+ short_desc => 'RRA: '
+ . $params->{contract_type}
+ . ' with '
+ . $params->{other_party},
+ product => 'Enterprise Information Security',
+ component => 'Rapid Risk Analysis',
+ bug_severity => 'normal',
+ groups => ['mozilla-employee-confidential'],
+ op_sys => 'All',
+ rep_platform => 'All',
+ version => 'unspecified',
+ blocked => $bug->bug_id,
+ cc => $params->{cc},
};
- $child_params->{'template_suffix'} = 'finance';
+ $child_params->{'template_suffix'} = 'sec-review';
_file_child_bug($child_params);
-
+ }
+
+ $child_params->{'bug_data'} = {
+ short_desc => 'Finance Review: '
+ . $params->{contract_type}
+ . ' with '
+ . $params->{other_party},
+ product => 'Finance',
+ component => 'Purchase Request Form',
+ bug_severity => 'normal',
+ priority => '--',
+ groups => ['finance'],
+ op_sys => 'All',
+ rep_platform => 'All',
+ version => 'unspecified',
+ blocked => $bug->bug_id,
+ cc => $params->{cc},
+ };
+ $child_params->{'template_suffix'} = 'finance';
+ _file_child_bug($child_params);
+
+ if (scalar @dep_errors) {
+ warn "[Bug "
+ . $bug->id
+ . "] Failed to create additional moz-project-review bugs:\n"
+ . join("\n", @dep_errors);
+ $vars->{'message'} = 'moz_project_review_creation_failed';
+ }
+
+ if (scalar @dep_comment) {
+ my $comment = join("\n", @dep_comment);
if (scalar @dep_errors) {
- warn "[Bug " . $bug->id . "] Failed to create additional moz-project-review bugs:\n" .
- join("\n", @dep_errors);
- $vars->{'message'} = 'moz_project_review_creation_failed';
- }
-
- if (scalar @dep_comment) {
- my $comment = join("\n", @dep_comment);
- if (scalar @dep_errors) {
- $comment .= "\n\nSome errors occurred creating dependent bugs and have been recorded";
- }
- $bug->add_comment($comment);
- $bug->update($bug->creation_ts);
+ $comment
+ .= "\n\nSome errors occurred creating dependent bugs and have been recorded";
}
+ $bug->add_comment($comment);
+ $bug->update($bug->creation_ts);
+ }
- foreach my $bug_id (@send_mail) {
- Bugzilla::BugMail::Send($bug_id, { changer => Bugzilla->user });
- }
+ foreach my $bug_id (@send_mail) {
+ Bugzilla::BugMail::Send($bug_id, {changer => Bugzilla->user});
+ }
}
sub _file_child_bug {
- my ($params) = @_;
- my ($parent_bug, $template_vars, $template_suffix, $bug_data, $dep_comment, $dep_errors, $send_mail)
- = @$params{qw(parent_bug template_vars template_suffix bug_data dep_comment dep_errors send_mail)};
-
- my $old_error_mode = Bugzilla->error_mode;
- Bugzilla->error_mode(ERROR_MODE_DIE);
-
- my $new_bug;
- eval {
- my $comment;
- my $full_template = "bug/create/comment-moz-project-review-$template_suffix.txt.tmpl";
- Bugzilla->template->process($full_template, $template_vars, \$comment)
- || ThrowTemplateError(Bugzilla->template->error());
- $bug_data->{'comment'} = $comment;
- if ($new_bug = Bugzilla::Bug->create($bug_data)) {
- my $set_all = {
- dependson => { add => [ $new_bug->bug_id ] }
- };
- $parent_bug->set_all($set_all);
- $parent_bug->update($parent_bug->creation_ts);
- }
+ my ($params) = @_;
+ my ($parent_bug, $template_vars, $template_suffix, $bug_data, $dep_comment,
+ $dep_errors, $send_mail)
+ = @$params{
+ qw(parent_bug template_vars template_suffix bug_data dep_comment dep_errors send_mail)
};
- if ($@ || !($new_bug && $new_bug->{'bug_id'})) {
- push(@$dep_comment, "Error creating $template_suffix review bug");
- push(@$dep_errors, "$template_suffix : $@") if $@;
- # Since we performed Bugzilla::Bug::create in an eval block, we
- # need to manually rollback the commit as this is not done
- # in Bugzilla::Error automatically for eval'ed code.
- Bugzilla->dbh->bz_rollback_transaction();
- }
- else {
- push(@$send_mail, $new_bug->id);
- push(@$dep_comment, "Bug " . $new_bug->id . " - " . $new_bug->short_desc);
+ my $old_error_mode = Bugzilla->error_mode;
+ Bugzilla->error_mode(ERROR_MODE_DIE);
+
+ my $new_bug;
+ eval {
+ my $comment;
+ my $full_template
+ = "bug/create/comment-moz-project-review-$template_suffix.txt.tmpl";
+ Bugzilla->template->process($full_template, $template_vars, \$comment)
+ || ThrowTemplateError(Bugzilla->template->error());
+ $bug_data->{'comment'} = $comment;
+ if ($new_bug = Bugzilla::Bug->create($bug_data)) {
+ my $set_all = {dependson => {add => [$new_bug->bug_id]}};
+ $parent_bug->set_all($set_all);
+ $parent_bug->update($parent_bug->creation_ts);
}
-
- undef $@;
- Bugzilla->error_mode($old_error_mode);
+ };
+
+ if ($@ || !($new_bug && $new_bug->{'bug_id'})) {
+ push(@$dep_comment, "Error creating $template_suffix review bug");
+ push(@$dep_errors, "$template_suffix : $@") if $@;
+
+ # Since we performed Bugzilla::Bug::create in an eval block, we
+ # need to manually rollback the commit as this is not done
+ # in Bugzilla::Error automatically for eval'ed code.
+ Bugzilla->dbh->bz_rollback_transaction();
+ }
+ else {
+ push(@$send_mail, $new_bug->id);
+ push(@$dep_comment, "Bug " . $new_bug->id . " - " . $new_bug->short_desc);
+ }
+
+ undef $@;
+ Bugzilla->error_mode($old_error_mode);
}
__PACKAGE__->NAME;
generated by cgit v1.2.3-24-g4f1b (git 2.32.0) at 2024-05-03 13:51:46 +0200