diff options
Diffstat (limited to 'qa/t/test_edit_products_properties.t')
| -rw-r--r-- | qa/t/test_edit_products_properties.t | 254 |
1 files changed, 154 insertions, 100 deletions
diff --git a/qa/t/test_edit_products_properties.t b/qa/t/test_edit_products_properties.t index b62e71061..848f81c63 100644 --- a/qa/t/test_edit_products_properties.t +++ b/qa/t/test_edit_products_properties.t @@ -15,15 +15,19 @@ use QA::Util; my ($sel, $config) = get_selenium(); -my $admin_user_login = $config->{admin_user_login}; +my $admin_user_login = $config->{admin_user_login}; my $unprivileged_user_login = $config->{unprivileged_user_login}; -my $permanent_user = $config->{permanent_user}; +my $permanent_user = $config->{permanent_user}; log_in($sel, $config, 'admin'); -set_parameters($sel, { "Bug Fields" => {"useclassification-off" => undef, - "usetargetmilestone-on" => undef}, - "Administrative Policies" => {"allowbugdeletion-on" => undef} - }); +set_parameters( + $sel, + { + "Bug Fields" => + {"useclassification-off" => undef, "usetargetmilestone-on" => undef}, + "Administrative Policies" => {"allowbugdeletion-on" => undef} + } +); # Create a product and add components to it. Do some cleanup first # if the script failed during a previous run. @@ -31,47 +35,54 @@ set_parameters($sel, { "Bug Fields" => {"useclassification-off" => go_to_admin($sel); $sel->click_ok("link=Products"); $sel->wait_for_page_to_load_ok(WAIT_TIME); + # No risk to get the "Select classification" page. We turned off useclassification. $sel->title_is("Select product"); my $text = trim($sel->get_text("bugzilla-body")); if ($text =~ /(Kill me!|Kill me nicely)/) { - my $product = $1; - my $escaped_product = url_quote($product); - $sel->click_ok("//a[\@href='editproducts.cgi?action=del&product=$escaped_product']"); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Delete Product '$product'"); - $sel->click_ok("delete"); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Product Deleted"); + my $product = $1; + my $escaped_product = url_quote($product); + $sel->click_ok( + "//a[\@href='editproducts.cgi?action=del&product=$escaped_product']"); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Delete Product '$product'"); + $sel->click_ok("delete"); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Product Deleted"); } $sel->click_ok("link=Add"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Add Product"); $sel->type_ok("product", "Kill me!"); -$sel->type_ok("description", "I will disappear very soon. Do not add bugs to it."); +$sel->type_ok("description", + "I will disappear very soon. Do not add bugs to it."); $sel->type_ok("defaultmilestone", "0.1a"); + # Since Bugzilla 4.0, the voting system is in an extension. if ($config->{test_extensions}) { - $sel->type_ok("votesperuser", "1"); - $sel->type_ok("maxvotesperbug", "1"); - $sel->type_ok("votestoconfirm", "10"); + $sel->type_ok("votesperuser", "1"); + $sel->type_ok("maxvotesperbug", "1"); + $sel->type_ok("votestoconfirm", "10"); } $sel->type_ok("version", "0.1a"); -$sel->select_ok("security_group_id", "label=core-security"); -$sel->select_ok("default_op_sys_id", "Unspecified"); +$sel->select_ok("security_group_id", "label=core-security"); +$sel->select_ok("default_op_sys_id", "Unspecified"); $sel->select_ok("default_platform_id", "Unspecified"); $sel->click_ok('//input[@type="submit" and @value="Add"]'); $sel->wait_for_page_to_load_ok(WAIT_TIME); $text = trim($sel->get_text("message")); -ok($text =~ /You will need to add at least one component before anyone can enter bugs against this product/, - "Display a reminder about missing components"); +ok( + $text + =~ /You will need to add at least one component before anyone can enter bugs against this product/, + "Display a reminder about missing components" +); $sel->click_ok("link=add at least one component"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Add component to the Kill me! product"); -$sel->type_ok("component", "first comp"); -$sel->type_ok("description", "comp 1"); +$sel->type_ok("component", "first comp"); +$sel->type_ok("description", "comp 1"); $sel->type_ok("initialowner", $admin_user_login); $sel->uncheck_ok("watch_user_auto"); $sel->type_ok("watch_user", "first-comp\@kill-me.bugs"); @@ -80,15 +91,16 @@ $sel->click_ok("create"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Component Created"); $text = trim($sel->get_text("message")); -ok($text eq 'The component first comp has been created.', "Component successfully created"); +ok($text eq 'The component first comp has been created.', + "Component successfully created"); # Try creating a second component with the same name. $sel->click_ok("link=Add"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Add component to the Kill me! product"); -$sel->type_ok("component", "first comp"); -$sel->type_ok("description", "comp 2"); +$sel->type_ok("component", "first comp"); +$sel->type_ok("description", "comp 2"); $sel->type_ok("initialowner", $admin_user_login); $sel->uncheck_ok("watch_user_auto"); $sel->type_ok("watch_user", "first-comp\@kill-me.bugs"); @@ -102,9 +114,10 @@ $sel->title_is("Component Already Exists"); $sel->go_back_ok(); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->type_ok("component", "second comp"); + # FIXME - Re-enter the default assignee (regression due to bug 577574) $sel->type_ok("initialowner", $admin_user_login); -$sel->type_ok("initialcc", $permanent_user); +$sel->type_ok("initialcc", $permanent_user); $sel->uncheck_ok("watch_user_auto"); $sel->type_ok("watch_user", "second-comp\@kill-me.bugs"); $sel->check_ok("watch_user_auto"); @@ -137,7 +150,7 @@ $sel->click_ok("link=Add"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Add Milestone to Product 'Kill me!'"); $sel->type_ok("milestone", "0.2"); -$sel->type_ok("sortkey", "2"); +$sel->type_ok("sortkey", "2"); $sel->click_ok("create"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Milestone Created"); @@ -148,6 +161,7 @@ $sel->click_ok("link=Add"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Add Milestone to Product 'Kill me!'"); $sel->type_ok("milestone", "0.1a"); + # Negative sortkeys are valid for milestones. $sel->type_ok("sortkey", "-2"); $sel->click_ok("create"); @@ -163,33 +177,39 @@ $sel->title_is("Milestone Created"); # Now create an UNCONFIRMED bug and add it to the newly created product. file_bug_in_product($sel, "Kill me!"); -$sel->select_ok("version", "label=0.1a"); +$sel->select_ok("version", "label=0.1a"); $sel->select_ok("component", "label=first comp"); + # UNCONFIRMED must be present. $sel->select_ok("bug_status", "label=UNCONFIRMED"); -$sel->type_ok("cc", $unprivileged_user_login); +$sel->type_ok("cc", $unprivileged_user_login); $sel->type_ok("bug_file_loc", "http://www.test.com"); -$sel->type_ok("short_desc", "test create/edit product properties"); -$sel->type_ok("comment", "this bug will soon be dead"); +$sel->type_ok("short_desc", "test create/edit product properties"); +$sel->type_ok("comment", "this bug will soon be dead"); $sel->click_ok("commit"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->is_text_present_ok('has been added to the database', 'Bug created'); my $bug1_id = $sel->get_value("//input[\@name='id' and \@type='hidden']"); my @cc_list = $sel->get_select_options("cc"); -ok(grep($_ eq $unprivileged_user_login, @cc_list), "$unprivileged_user_login correctly added to the CC list"); -ok(!grep($_ eq $permanent_user, @cc_list), "$permanent_user not in the CC list for 'first comp' by default"); +ok( + grep($_ eq $unprivileged_user_login, @cc_list), + "$unprivileged_user_login correctly added to the CC list" +); +ok(!grep($_ eq $permanent_user, @cc_list), + "$permanent_user not in the CC list for 'first comp' by default"); # File a second bug, and make sure users in the default CC list are added. file_bug_in_product($sel, "Kill me!"); -$sel->select_ok("version", "label=0.1a"); +$sel->select_ok("version", "label=0.1a"); $sel->select_ok("component", "label=second comp"); $sel->type_ok("short_desc", "check default CC list"); -$sel->type_ok("comment", "is the CC list populated correctly?"); +$sel->type_ok("comment", "is the CC list populated correctly?"); $sel->click_ok("commit"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->is_text_present_ok('has been added to the database', 'Bug created'); @cc_list = $sel->get_select_options("cc"); -ok(grep($_ eq $permanent_user, @cc_list), "$permanent_user in the CC list for 'second comp' by default"); +ok(grep($_ eq $permanent_user, @cc_list), + "$permanent_user in the CC list for 'second comp' by default"); # Edit product properties and set votes_to_confirm to 0, which has # the side-effect to disable auto-confirmation (new behavior compared @@ -197,67 +217,78 @@ ok(grep($_ eq $permanent_user, @cc_list), "$permanent_user in the CC list for 's edit_product($sel, "Kill me!"); $sel->type_ok("product", "Kill me nicely"); -$sel->type_ok("description", "I will disappear very soon. Do not add bugs to it (except for testing)."); +$sel->type_ok("description", + "I will disappear very soon. Do not add bugs to it (except for testing)."); $sel->select_ok("defaultmilestone", "label=0.2"); if ($config->{test_extensions}) { - $sel->type_ok("votesperuser", "2"); - $sel->type_ok("maxvotesperbug", 5); - $sel->type_ok("votestoconfirm", "0"); + $sel->type_ok("votesperuser", "2"); + $sel->type_ok("maxvotesperbug", 5); + $sel->type_ok("votestoconfirm", "0"); } $sel->click_ok('//input[@type="submit" and @value="Save Changes"]'); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Updating Product 'Kill me nicely'"); -$sel->is_text_present_ok("Updated product name from 'Kill me!' to 'Kill me nicely'"); +$sel->is_text_present_ok( + "Updated product name from 'Kill me!' to 'Kill me nicely'"); $sel->is_text_present_ok("Updated description"); $sel->is_text_present_ok("Updated default milestone"); if ($config->{test_extensions}) { - $sel->is_text_present_ok("Updated votes per user"); - $sel->is_text_present_ok("Updated maximum votes per bug"); - $sel->is_text_present_ok("Updated number of votes needed to confirm a bug"); - $text = trim($sel->get_text("bugzilla-body")); - # We use .{1} in place of the right arrow character, which fails otherwise. - ok($text =~ /Checking unconfirmed bugs in this product for any which now have sufficient votes\.{3} .{1}there were none/, - "No bugs confirmed by popular votes (votestoconfirm = 0 disables auto-confirmation)"); - - # Now set votestoconfirm to 2, vote for a bug, and then set - # this attribute back to 1, to trigger auto-confirmation. - - $sel->click_ok("link=Kill me nicely"); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Edit Product 'Kill me nicely'", "Display properties of Kill me nicely"); - $sel->type_ok("votestoconfirm", 2); - $sel->click_ok('//input[@type="submit" and @value="Save Changes"]'); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Updating Product 'Kill me nicely'"); - $sel->is_text_present_ok("Updated number of votes needed to confirm a bug"); - - go_to_bug($sel, $bug1_id); - $sel->click_ok("link=vote"); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Change Votes"); - $sel->type_ok("bug_$bug1_id", 1); - $sel->click_ok("change"); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Change Votes"); - $sel->is_text_present_ok("The changes to your votes have been saved"); - - edit_product($sel, "Kill me nicely"); - $sel->type_ok("votestoconfirm", 1); - $sel->click_ok('//input[@type="submit" and @value="Save Changes"]'); - $sel->wait_for_page_to_load_ok(WAIT_TIME); - $sel->title_is("Updating Product 'Kill me nicely'"); - $sel->is_text_present_ok("Updated number of votes needed to confirm a bug"); - $text = trim($sel->get_text("bugzilla-body")); - ok($text =~ /Bug $bug1_id confirmed by number of votes/, "Bug $bug1_id is confirmed by popular votes"); + $sel->is_text_present_ok("Updated votes per user"); + $sel->is_text_present_ok("Updated maximum votes per bug"); + $sel->is_text_present_ok("Updated number of votes needed to confirm a bug"); + $text = trim($sel->get_text("bugzilla-body")); + + # We use .{1} in place of the right arrow character, which fails otherwise. + ok( + $text + =~ /Checking unconfirmed bugs in this product for any which now have sufficient votes\.{3} .{1}there were none/, + "No bugs confirmed by popular votes (votestoconfirm = 0 disables auto-confirmation)" + ); + + # Now set votestoconfirm to 2, vote for a bug, and then set + # this attribute back to 1, to trigger auto-confirmation. + + $sel->click_ok("link=Kill me nicely"); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Edit Product 'Kill me nicely'", + "Display properties of Kill me nicely"); + $sel->type_ok("votestoconfirm", 2); + $sel->click_ok('//input[@type="submit" and @value="Save Changes"]'); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Updating Product 'Kill me nicely'"); + $sel->is_text_present_ok("Updated number of votes needed to confirm a bug"); + + go_to_bug($sel, $bug1_id); + $sel->click_ok("link=vote"); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Change Votes"); + $sel->type_ok("bug_$bug1_id", 1); + $sel->click_ok("change"); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Change Votes"); + $sel->is_text_present_ok("The changes to your votes have been saved"); + + edit_product($sel, "Kill me nicely"); + $sel->type_ok("votestoconfirm", 1); + $sel->click_ok('//input[@type="submit" and @value="Save Changes"]'); + $sel->wait_for_page_to_load_ok(WAIT_TIME); + $sel->title_is("Updating Product 'Kill me nicely'"); + $sel->is_text_present_ok("Updated number of votes needed to confirm a bug"); + $text = trim($sel->get_text("bugzilla-body")); + ok( + $text =~ /Bug $bug1_id confirmed by number of votes/, + "Bug $bug1_id is confirmed by popular votes" + ); } # Edit the bug. go_to_bug($sel, $bug1_id); -$sel->selected_label_is("product", "Kill me nicely"); -$sel->selected_label_is("bug_status", "CONFIRMED") if $config->{test_extensions}; +$sel->selected_label_is("product", "Kill me nicely"); +$sel->selected_label_is("bug_status", "CONFIRMED") + if $config->{test_extensions}; $sel->select_ok("target_milestone", "label=pre-0.1"); -$sel->select_ok("component", "label=second comp"); +$sel->select_ok("component", "label=second comp"); $sel->click_ok("commit"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->is_text_present_ok("Changes submitted for bug $bug1_id"); @@ -265,7 +296,8 @@ $sel->click_ok("link=bug $bug1_id"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_like(qr/$bug1_id /); @cc_list = $sel->get_select_options("cc"); -ok(grep($_ eq $permanent_user, @cc_list), "User $permanent_user automatically added to the CC list"); +ok(grep($_ eq $permanent_user, @cc_list), + "User $permanent_user automatically added to the CC list"); # Delete the milestone the bug belongs to. This should retarget the bug # to the default milestone. @@ -274,17 +306,24 @@ edit_product($sel, "Kill me nicely"); $sel->click_ok("link=Edit milestones:"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Select milestone of product 'Kill me nicely'"); -$sel->click_ok('//a[@href="editmilestones.cgi?action=del&product=Kill%20me%20nicely&milestone=pre-0.1"]'); +$sel->click_ok( + '//a[@href="editmilestones.cgi?action=del&product=Kill%20me%20nicely&milestone=pre-0.1"]' +); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Delete Milestone of Product 'Kill me nicely'"); $text = trim($sel->get_text("bugzilla-body")); ok($text =~ /There is 1 bug entered for this milestone/, "Warning displayed"); -ok($text =~ /Do you really want to delete this milestone\?/, "Requesting confirmation"); +ok($text =~ /Do you really want to delete this milestone\?/, + "Requesting confirmation"); $sel->click_ok("delete"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Milestone Deleted"); $text = trim($sel->get_text("message")); -ok($text =~ /Bugs targetted to this milestone have been retargetted to the default milestone/, "Bug retargetted"); +ok( + $text + =~ /Bugs targetted to this milestone have been retargetted to the default milestone/, + "Bug retargetted" +); # Try deleting the version used by the bug. This action must be rejected. @@ -294,21 +333,27 @@ $sel->title_is("Edit Product 'Kill me nicely'"); $sel->click_ok("//a[contains(text(),'Edit\nversions:')]"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Select version of product 'Kill me nicely'"); -$sel->click_ok("//a[contains(\@href, 'editversions.cgi?action=del&product=Kill%20me%20nicely&version=0.1a')]"); +$sel->click_ok( + "//a[contains(\@href, 'editversions.cgi?action=del&product=Kill%20me%20nicely&version=0.1a')]" +); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Delete Version of Product 'Kill me nicely'"); $text = trim($sel->get_text("bugzilla-body")); -ok($text =~ /Sorry, there are 2 bugs outstanding for this version/, "Rejecting version deletion"); +ok($text =~ /Sorry, there are 2 bugs outstanding for this version/, + "Rejecting version deletion"); $sel->go_back_ok(); $sel->wait_for_page_to_load_ok(WAIT_TIME); # Delete an unused version. The action must succeed. -$sel->click_ok('//a[@href="editversions.cgi?action=del&product=Kill%20me%20nicely&version=0.1"]'); +$sel->click_ok( + '//a[@href="editversions.cgi?action=del&product=Kill%20me%20nicely&version=0.1"]' +); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Delete Version of Product 'Kill me nicely'"); $text = trim($sel->get_text("bugzilla-body")); -ok($text =~ /Do you really want to delete this version\?/, "Requesting confirmation"); +ok($text =~ /Do you really want to delete this version\?/, + "Requesting confirmation"); $sel->click_ok("delete"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Version Deleted"); @@ -321,26 +366,33 @@ $sel->title_is("Edit Product 'Kill me nicely'"); $sel->click_ok("link=Edit components:"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Select component of product 'Kill me nicely'"); -$sel->click_ok("//a[contains(\@href, 'editcomponents.cgi?action=del&product=Kill%20me%20nicely&component=second%20comp')]"); +$sel->click_ok( + "//a[contains(\@href, 'editcomponents.cgi?action=del&product=Kill%20me%20nicely&component=second%20comp')]" +); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Delete component 'second comp' from 'Kill me nicely' product"); $text = trim($sel->get_text("bugzilla-body")); ok($text =~ /There are 2 bugs entered for this component/, "Warning displayed"); -ok($text =~ /Do you really want to delete this component\?/, "Requesting confirmation"); +ok($text =~ /Do you really want to delete this component\?/, + "Requesting confirmation"); $sel->click_ok("delete"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Component Deleted"); $text = trim($sel->get_text("bugzilla-body")); -ok($text =~ /The component second comp has been deleted/, "Component deletion confirmed"); -ok($text =~ /All bugs being in this component and all references to them have also been deleted/, - "Bug deletion confirmed"); +ok($text =~ /The component second comp has been deleted/, + "Component deletion confirmed"); +ok( + $text + =~ /All bugs being in this component and all references to them have also been deleted/, + "Bug deletion confirmed" +); # Only one value for component, version and milestone available. They should # be selected by default. file_bug_in_product($sel, "Kill me nicely"); $sel->type_ok("short_desc", "bye bye everybody!"); -$sel->type_ok("comment", "I'm dead :("); +$sel->type_ok("comment", "I'm dead :("); $sel->click_ok("commit"); $sel->wait_for_page_to_load_ok(WAIT_TIME); @@ -350,12 +402,14 @@ go_to_admin($sel); $sel->click_ok("link=Products"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Select product"); -$sel->click_ok("//a[\@href='editproducts.cgi?action=del&product=Kill%20me%20nicely']"); +$sel->click_ok( + "//a[\@href='editproducts.cgi?action=del&product=Kill%20me%20nicely']"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Delete Product 'Kill me nicely'"); $text = trim($sel->get_text("bugzilla-body")); ok($text =~ /There is 1 bug entered for this product/, "Warning displayed"); -ok($text =~ /Do you really want to delete this product\?/, "Confirmation request displayed"); +ok($text =~ /Do you really want to delete this product\?/, + "Confirmation request displayed"); $sel->click_ok("delete"); $sel->wait_for_page_to_load_ok(WAIT_TIME); $sel->title_is("Product Deleted"); |