summaryrefslogtreecommitdiffstats
path: root/qa/t/webservice_bug_attachments.t
diff options
context:
space:
mode:
Diffstat (limited to 'qa/t/webservice_bug_attachments.t')
-rw-r--r--qa/t/webservice_bug_attachments.t213
1 files changed, 117 insertions, 96 deletions
diff --git a/qa/t/webservice_bug_attachments.t b/qa/t/webservice_bug_attachments.t
index daa5032a3..cd2e6bfa4 100644
--- a/qa/t/webservice_bug_attachments.t
+++ b/qa/t/webservice_bug_attachments.t
@@ -23,36 +23,41 @@ my ($config, @clients) = get_rpc_clients();
our %attachments;
sub post_bug_success {
- my ($call, $t) = @_;
-
- my $bugs = $call->result->{bugs};
- is(scalar keys %$bugs, 1, "Got exactly one bug")
- or diag(Dumper($call->result));
-
- my $bug_attachments = (values %$bugs)[0];
- # Collect attachment ids
- foreach my $alias (qw(public_bug private_bug)) {
- foreach my $is_private (0, 1) {
- my $find_desc = "${alias}_${is_private}";
- my $attachment = first { $_->{summary} eq $find_desc }
- reverse @$bug_attachments;
- if ($attachment) {
- $attachments{$find_desc} = $attachment->{id};
- }
- }
+ my ($call, $t) = @_;
+
+ my $bugs = $call->result->{bugs};
+ is(scalar keys %$bugs, 1, "Got exactly one bug") or diag(Dumper($call->result));
+
+ my $bug_attachments = (values %$bugs)[0];
+
+ # Collect attachment ids
+ foreach my $alias (qw(public_bug private_bug)) {
+ foreach my $is_private (0, 1) {
+ my $find_desc = "${alias}_${is_private}";
+ my $attachment = first { $_->{summary} eq $find_desc }
+ reverse @$bug_attachments;
+ if ($attachment) {
+ $attachments{$find_desc} = $attachment->{id};
+ }
}
+ }
}
foreach my $rpc (@clients) {
- $rpc->bz_run_tests(tests => STANDARD_BUG_TESTS, method => 'Bug.attachments',
- post_success => \&post_bug_success);
+ $rpc->bz_run_tests(
+ tests => STANDARD_BUG_TESTS,
+ method => 'Bug.attachments',
+ post_success => \&post_bug_success
+ );
}
foreach my $alias (qw(public_bug private_bug)) {
- foreach my $is_private (0, 1) {
- ok($attachments{"${alias}_${is_private}"},
- "Found attachment id for ${alias}_${is_private}");
- }
+ foreach my $is_private (0, 1) {
+ ok(
+ $attachments{"${alias}_${is_private}"},
+ "Found attachment id for ${alias}_${is_private}"
+ );
+ }
}
####################
@@ -69,83 +74,99 @@ close($fh);
# format of each return value is correct.
my @tests = (
- # Logged-out user
- { args => { attachment_ids => [$attachments{'public_bug_0'}] },
- test => 'Logged-out user can access public attachment on public'
- . ' bug by id',
- },
- { args => { attachment_ids => [$attachments{'public_bug_1'}] },
- test => 'Logged-out user cannot access private attachment on public bug',
- error => 'Sorry, you are not authorized',
- },
- { args => { attachment_ids => [$attachments{'private_bug_0'}] },
- test => 'Logged-out user cannot access attachments by id on private bug',
- error => 'You are not authorized to access',
- },
- { args => { attachment_ids => [$attachments{'private_bug_1'}] },
- test => 'Logged-out user cannot access private attachment on '
- . ' private bug',
- error => 'You are not authorized to access',
- },
-
- # Logged-in, unprivileged user.
- { user => 'unprivileged',
- args => { attachment_ids => [$attachments{'public_bug_0'}] },
- test => 'Logged-in user can see a public attachment on a public bug by id',
- },
- { user => 'unprivileged',
- args => { attachment_ids => [$attachments{'public_bug_1'}] },
- test => 'Logged-in user cannot access private attachment on public bug',
- error => 'Sorry, you are not authorized',
- },
- { user => 'unprivileged',
- args => { attachment_ids => [$attachments{'private_bug_0'}] },
- test => 'Logged-in user cannot access attachments by id on private bug',
- error => "You are not authorized to access",
- },
- { user => 'unprivileged',
- args => { attachment_ids => [$attachments{'private_bug_1'}] },
- test => 'Logged-in user cannot access private attachment on private bug',
- error => "You are not authorized to access",
- },
-
- # User who can see private bugs and private attachments
- { user => PRIVATE_BUG_USER,
- args => { attachment_ids => [$attachments{'public_bug_1'}] },
- test => PRIVATE_BUG_USER . ' can see private attachment on public bug',
- },
- { user => PRIVATE_BUG_USER,
- args => { attachment_ids => [$attachments{'private_bug_1'}] },
- test => PRIVATE_BUG_USER . ' can see private attachment on private bug',
- },
+
+ # Logged-out user
+ {
+ args => {attachment_ids => [$attachments{'public_bug_0'}]},
+ test => 'Logged-out user can access public attachment on public'
+ . ' bug by id',
+ },
+ {
+ args => {attachment_ids => [$attachments{'public_bug_1'}]},
+ test => 'Logged-out user cannot access private attachment on public bug',
+ error => 'Sorry, you are not authorized',
+ },
+ {
+ args => {attachment_ids => [$attachments{'private_bug_0'}]},
+ test => 'Logged-out user cannot access attachments by id on private bug',
+ error => 'You are not authorized to access',
+ },
+ {
+ args => {attachment_ids => [$attachments{'private_bug_1'}]},
+ test => 'Logged-out user cannot access private attachment on ' . ' private bug',
+ error => 'You are not authorized to access',
+ },
+
+ # Logged-in, unprivileged user.
+ {
+ user => 'unprivileged',
+ args => {attachment_ids => [$attachments{'public_bug_0'}]},
+ test => 'Logged-in user can see a public attachment on a public bug by id',
+ },
+ {
+ user => 'unprivileged',
+ args => {attachment_ids => [$attachments{'public_bug_1'}]},
+ test => 'Logged-in user cannot access private attachment on public bug',
+ error => 'Sorry, you are not authorized',
+ },
+ {
+ user => 'unprivileged',
+ args => {attachment_ids => [$attachments{'private_bug_0'}]},
+ test => 'Logged-in user cannot access attachments by id on private bug',
+ error => "You are not authorized to access",
+ },
+ {
+ user => 'unprivileged',
+ args => {attachment_ids => [$attachments{'private_bug_1'}]},
+ test => 'Logged-in user cannot access private attachment on private bug',
+ error => "You are not authorized to access",
+ },
+
+ # User who can see private bugs and private attachments
+ {
+ user => PRIVATE_BUG_USER,
+ args => {attachment_ids => [$attachments{'public_bug_1'}]},
+ test => PRIVATE_BUG_USER . ' can see private attachment on public bug',
+ },
+ {
+ user => PRIVATE_BUG_USER,
+ args => {attachment_ids => [$attachments{'private_bug_1'}]},
+ test => PRIVATE_BUG_USER . ' can see private attachment on private bug',
+ },
);
sub post_success {
- my ($call, $t, $rpc) = @_;
- is(scalar keys %{ $call->result->{attachments} }, 1,
- "Got exactly one attachment");
- my $attachment = (values %{ $call->result->{attachments} })[0];
-
- cmp_ok($attachment->{last_change_time}, '=~', $rpc->DATETIME_REGEX,
- "last_change_time is in the right format");
- cmp_ok($attachment->{creation_time}, '=~', $rpc->DATETIME_REGEX,
- "creation_time is in the right format");
- is($attachment->{is_obsolete}, 0, 'is_obsolete is 0');
- cmp_ok($attachment->{bug_id}, '=~', qr/^\d+$/, "bug_id is an integer");
- cmp_ok($attachment->{id}, '=~', qr/^\d+$/, "id is an integer");
- is($attachment->{content_type}, 'application/x-perl',
- "content_type is correct");
- cmp_ok($attachment->{file_name}, '=~', qr/^\w+\.pl$/,
- "filename is in the expected format");
- is($attachment->{creator}, $config->{QA_Selenium_TEST_user_login},
- "creator is the correct user");
- my $data = $attachment->{data};
- $data = decode_base64($data) if $rpc->isa('QA::RPC::JSONRPC');
- is($data, $content, 'data is correct');
- is($attachment->{size}, length($data), "size matches data's size");
+ my ($call, $t, $rpc) = @_;
+ is(scalar keys %{$call->result->{attachments}}, 1,
+ "Got exactly one attachment");
+ my $attachment = (values %{$call->result->{attachments}})[0];
+
+ cmp_ok($attachment->{last_change_time},
+ '=~', $rpc->DATETIME_REGEX, "last_change_time is in the right format");
+ cmp_ok($attachment->{creation_time},
+ '=~', $rpc->DATETIME_REGEX, "creation_time is in the right format");
+ is($attachment->{is_obsolete}, 0, 'is_obsolete is 0');
+ cmp_ok($attachment->{bug_id}, '=~', qr/^\d+$/, "bug_id is an integer");
+ cmp_ok($attachment->{id}, '=~', qr/^\d+$/, "id is an integer");
+ is($attachment->{content_type}, 'application/x-perl',
+ "content_type is correct");
+ cmp_ok($attachment->{file_name},
+ '=~', qr/^\w+\.pl$/, "filename is in the expected format");
+ is(
+ $attachment->{creator},
+ $config->{QA_Selenium_TEST_user_login},
+ "creator is the correct user"
+ );
+ my $data = $attachment->{data};
+ $data = decode_base64($data) if $rpc->isa('QA::RPC::JSONRPC');
+ is($data, $content, 'data is correct');
+ is($attachment->{size}, length($data), "size matches data's size");
}
foreach my $rpc (@clients) {
- $rpc->bz_run_tests(method => 'Bug.attachments', tests => \@tests,
- post_success => \&post_success);
+ $rpc->bz_run_tests(
+ method => 'Bug.attachments',
+ tests => \@tests,
+ post_success => \&post_success
+ );
}
generated by cgit v1.2.3-24-g4f1b (git 2.32.0) at 2024-05-03 14:37:59 +0200