diff options
Diffstat (limited to 'qa/t/webservice_user_create.t')
| -rw-r--r-- | qa/t/webservice_user_create.t | 170 |
1 files changed, 98 insertions, 72 deletions
diff --git a/qa/t/webservice_user_create.t b/qa/t/webservice_user_create.t index 34b7a4896..33b042a51 100644 --- a/qa/t/webservice_user_create.t +++ b/qa/t/webservice_user_create.t @@ -25,90 +25,116 @@ use constant PASSWORD_TOO_SHORT => 'a'; use constant INVALID_EMAIL => '()[]\;:,<>@webservice.test'; sub new_login { - return 'created_' . random_string(@_) . '@webservice.test'; + return 'created_' . random_string(@_) . '@webservice.test'; } sub post_success { - my ($call) = @_; - ok($call->result->{id}, "Got a non-zero user id"); + my ($call) = @_; + ok($call->result->{id}, "Got a non-zero user id"); } -$jsonrpc_get->bz_call_fail('User.create', - { email => new_login(), full_name => NEW_FULLNAME, - password => '*' }, - 'must use HTTP POST', 'User.create fails over GET'); +$jsonrpc_get->bz_call_fail( + 'User.create', + {email => new_login(), full_name => NEW_FULLNAME, password => '*'}, + 'must use HTTP POST', + 'User.create fails over GET' +); # We have to wrap @tests in the foreach, because we want a different # login for each user, separately for each RPC client. (You can't create # two users with the same username, and XML-RPC would otherwise try to # create the same users that JSON-RPC created.) foreach my $rpc ($jsonrpc, $xmlrpc) { - my @tests = ( - # Permissions checks - { args => { email => new_login(), full_name => NEW_FULLNAME, - password => NEW_PASSWORD }, - error => "you are not authorized", - test => 'Logged-out user cannot call User.create', - }, - { user => 'unprivileged', - args => { email => new_login(), full_name => NEW_FULLNAME, - password => NEW_PASSWORD }, - error => "you are not authorized", - test => 'Unprivileged user cannot call User.create', - }, + my @tests = ( - # Login name checks. - { user => 'admin', - args => { full_name => NEW_FULLNAME, password => NEW_PASSWORD }, - error => "argument was not set", - test => 'Leaving out email argument fails', - }, - { user => 'admin', - args => { email => '', full_name => NEW_FULLNAME, - password => NEW_PASSWORD }, - error => "argument was not set", - test => "Passing an empty email argument fails", - }, - { user => 'admin', - args => { email => INVALID_EMAIL, full_name => NEW_FULLNAME, - password => NEW_PASSWORD }, - error => "didn't pass our syntax checking", - test => 'Invalid email address fails', - }, - { user => 'admin', - args => { email => new_login(128), full_name => NEW_FULLNAME, - password => NEW_PASSWORD }, - error => "didn't pass our syntax checking", - test => 'Too long (> 127 chars) email address fails', - }, - { user => 'admin', - args => { email => $config->{unprivileged_user_login}, - full_name => NEW_FULLNAME, password => NEW_PASSWORD }, - error => "There is already an account", - test => 'Trying to use an existing login name fails', - }, + # Permissions checks + { + args => + {email => new_login(), full_name => NEW_FULLNAME, password => NEW_PASSWORD}, + error => "you are not authorized", + test => 'Logged-out user cannot call User.create', + }, + { + user => 'unprivileged', + args => + {email => new_login(), full_name => NEW_FULLNAME, password => NEW_PASSWORD}, + error => "you are not authorized", + test => 'Unprivileged user cannot call User.create', + }, - { user => 'admin', - args => { email => new_login(), full_name => NEW_FULLNAME, - password => PASSWORD_TOO_SHORT }, - error => 'The password does not meet our security requirements for the following reason: too short', - test => 'Password Too Short fails', - }, - { user => 'admin', - args => { email => new_login(), full_name => NEW_FULLNAME, - password => NEW_PASSWORD }, - test => 'Creating a user with all arguments and correct privileges', - }, - { user => 'admin', - args => { email => new_login(), password => NEW_PASSWORD }, - test => 'Leaving out fullname works', - }, - { user => 'admin', - args => { email => new_login(), full_name => NEW_FULLNAME }, - test => 'Leaving out password works', - }, - ); + # Login name checks. + { + user => 'admin', + args => {full_name => NEW_FULLNAME, password => NEW_PASSWORD}, + error => "argument was not set", + test => 'Leaving out email argument fails', + }, + { + user => 'admin', + args => {email => '', full_name => NEW_FULLNAME, password => NEW_PASSWORD}, + error => "argument was not set", + test => "Passing an empty email argument fails", + }, + { + user => 'admin', + args => + {email => INVALID_EMAIL, full_name => NEW_FULLNAME, password => NEW_PASSWORD}, + error => "didn't pass our syntax checking", + test => 'Invalid email address fails', + }, + { + user => 'admin', + args => { + email => new_login(128), + full_name => NEW_FULLNAME, + password => NEW_PASSWORD + }, + error => "didn't pass our syntax checking", + test => 'Too long (> 127 chars) email address fails', + }, + { + user => 'admin', + args => { + email => $config->{unprivileged_user_login}, + full_name => NEW_FULLNAME, + password => NEW_PASSWORD + }, + error => "There is already an account", + test => 'Trying to use an existing login name fails', + }, - $rpc->bz_run_tests(tests => \@tests, method => 'User.create', - post_success => \&post_success); + { + user => 'admin', + args => { + email => new_login(), + full_name => NEW_FULLNAME, + password => PASSWORD_TOO_SHORT + }, + error => + 'The password does not meet our security requirements for the following reason: too short', + test => 'Password Too Short fails', + }, + { + user => 'admin', + args => + {email => new_login(), full_name => NEW_FULLNAME, password => NEW_PASSWORD}, + test => 'Creating a user with all arguments and correct privileges', + }, + { + user => 'admin', + args => {email => new_login(), password => NEW_PASSWORD}, + test => 'Leaving out fullname works', + }, + { + user => 'admin', + args => {email => new_login(), full_name => NEW_FULLNAME}, + test => 'Leaving out password works', + }, + ); + + $rpc->bz_run_tests( + tests => \@tests, + method => 'User.create', + post_success => \&post_success + ); } |