summaryrefslogtreecommitdiffstats
path: root/js/instant-search.js
AgeCommit message (Collapse)AuthorFilesLines
2018-04-08Bug 1446236 - Fix instant search without GuidedBugEntry (#38)Vladimir Panteleev1-2/+2
* instant-search.js: Don't fail if product map isn't loaded getProduct had a hard dependency on the 'products' object, which is provided by products.js from the GuidedBugEntry extension. Check if the products variable exists before attempting to use it. This can happen when loading products.js fails, which in turn can happen when the GuidedBugEntry extension isn't present. * Instant search: Don't load products.js without GuidedBugEntry Fixes a 404 if the GuidedBugEntry extension is not present. * instant-search.js: Use throbber.gif from core Fixes remaining dependency on GuidedBugEntry.
2018-04-03Bug 1450920 - Don't pass blank API token to JSON-PRC in instant searchVladimir Panteleev1-2/+4
When an API token is seen by JSON-RPC, it will attempt to authenticate it, including blank tokens (empty strings). Thus, avoid passing an empty string in the first place. The pattern to pass an empty string if the absence of BUGZILLA.api_token is the most common way to include the Bugzilla_api_token in the JSON-PRC requests. However, most places which pass a token to JSON-RPC in JavaScript are in contexts where a user is expected to be logged in, and this is not the case for instant search. Although this could have been fixed by patching Bugzilla::Auth::Login::Cookie::get_login_info to treat empty API tokens as if none were given, this method was chosen, as this is also the approach used in the ProdCompSearch extension (where a login session also does not need to be required), and to avoid possible breakage in JSON-RPC consumers.
2018-01-03Bug 1426685 - Fix regressions from fixed-positioning global headerKohei Yoshino1-1/+0
2015-09-01Bug 1200610: jsonrpc API requests do not work when "Require API-Key ↵David Lawrence1-1/+2
authentication for API requests" is enabled due to missing API tokens
2012-02-03Bug 723646: fix broken instant searchByron Jones1-1/+1
2012-01-23Bug 719363: add instant searchByron Jones1-0/+201