From 05f4f669786cc08853eff42e92ce91a56e971224 Mon Sep 17 00:00:00 2001 From: Dave Lawrence Date: Wed, 4 Sep 2013 10:23:47 -0400 Subject: Bug 898830 - Improve loading of show_bug.cgi - Oracle doesn't like 'size' as column alias. It's a reserved word. --- Bugzilla/Attachment.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index a544ed614..bf67b62fa 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -697,13 +697,13 @@ sub get_attachments_by_bug { # Preload datasizes. my $sizes = - $dbh->selectall_hashref('SELECT attach_id, LENGTH(thedata) AS size + $dbh->selectall_hashref('SELECT attach_id, LENGTH(thedata) AS datasize FROM attachments LEFT JOIN attach_data ON attach_id = id WHERE bug_id = ?', 'attach_id', undef, $bug_id); # Force the size of attachments not in the DB to be recalculated. - $_->{datasize} = $sizes->{$_->id}->{size} || undef foreach @$attachments; + $_->{datasize} = $sizes->{$_->id}->{datasize} || undef foreach @$attachments; } return $attachments; } -- cgit v1.2.3-24-g4f1b