From 88c0ad4221cdc1eed917fa6bea612d53afbf1727 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Sat, 25 Feb 2012 15:08:23 +0100 Subject: Bug 730552: HTML markup validation: unescaped "&" in CSV link on buglist.cgi r=timello a=LpSolit --- template/en/default/list/list.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/en/default/list/list.html.tmpl b/template/en/default/list/list.html.tmpl index 27d1eb027..4eeff5e64 100644 --- a/template/en/default/list/list.html.tmpl +++ b/template/en/default/list/list.html.tmpl @@ -202,7 +202,7 @@ CSV | + [% urlquerypart FILTER html %]&ctype=csv&human=1">CSV | Feed | -- cgit v1.2.3-24-g4f1b From d1b309b7d5cb8e07a9840baca4799c52ce158813 Mon Sep 17 00:00:00 2001 From: Michal 'hramrach' Suchanek Date: Sat, 25 Feb 2012 15:19:07 +0100 Subject: Bug 696352: Required fields have broken colors r/a=LpSolit --- skins/standard/global.css | 1 + 1 file changed, 1 insertion(+) diff --git a/skins/standard/global.css b/skins/standard/global.css index e8336d5c1..1a09dbc25 100644 --- a/skins/standard/global.css +++ b/skins/standard/global.css @@ -502,6 +502,7 @@ th.required:before, span.required_star { } input.required, select.required, span.required_explanation { background-color: #fff7cd; + color: #000; } .calendar_button { -- cgit v1.2.3-24-g4f1b From 5c7b519fd62222b18202e93889748008e698d5c1 Mon Sep 17 00:00:00 2001 From: Matt Selsky Date: Sun, 26 Feb 2012 12:51:11 +0100 Subject: Bug 714368: Add Windows 8 detection r/a=LpSolit --- enter_bug.cgi | 1 + 1 file changed, 1 insertion(+) diff --git a/enter_bug.cgi b/enter_bug.cgi index 4778e4418..ce50a2ce6 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -294,6 +294,7 @@ sub pickos { /\(.*VMS.*\)/ && do {push @os, "OpenVMS";}; /\(.*Win.*\)/ && do { /\(.*Windows XP.*\)/ && do {push @os, "Windows XP";}; + /\(.*Windows NT 6\.2.*\)/ && do {push @os, "Windows 8";}; /\(.*Windows NT 6\.1.*\)/ && do {push @os, "Windows 7";}; /\(.*Windows NT 6\.0.*\)/ && do {push @os, "Windows Vista";}; /\(.*Windows NT 5\.2.*\)/ && do {push @os, "Windows Server 2003";}; -- cgit v1.2.3-24-g4f1b From 0f9e374c20bb56cf1df8733863d42f0660b8510a Mon Sep 17 00:00:00 2001 From: Matt Selsky Date: Sun, 26 Feb 2012 12:52:49 +0100 Subject: Bug 714030: Add Mac OS 10.7 Lion detection r/a=LpSolit --- enter_bug.cgi | 1 + 1 file changed, 1 insertion(+) diff --git a/enter_bug.cgi b/enter_bug.cgi index ce50a2ce6..59edc2e13 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -310,6 +310,7 @@ sub pickos { /\(.*Windows.*NT.*\)/ && do {push @os, "Windows NT";}; }; /\(.*Mac OS X.*\)/ && do { + /\(.*Mac OS X (?:|Mach-O |\()10.7.*\)/ && do {push @os, "Mac OS X 10.7";}; /\(.*Mac OS X (?:|Mach-O |\()10.6.*\)/ && do {push @os, "Mac OS X 10.6";}; /\(.*Mac OS X (?:|Mach-O |\()10.5.*\)/ && do {push @os, "Mac OS X 10.5";}; /\(.*Mac OS X (?:|Mach-O |\()10.4.*\)/ && do {push @os, "Mac OS X 10.4";}; -- cgit v1.2.3-24-g4f1b From 4de13f571f0119c313a223474c1e64d7bdf6146f Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 27 Feb 2012 15:10:45 +0100 Subject: Bug 730598: Running checksetup.pl twice deletes the DEFAULT value of the bug_see_also.class column r=timello a=LpSolit --- Bugzilla/Install/DB.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index 28c762d28..6b9dd65cd 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -3600,7 +3600,7 @@ sub _populate_bug_see_also_class { if ($dbh->bz_column_info('bug_see_also', 'class')) { # The length was incorrectly set to 64 instead of 255. $dbh->bz_alter_column('bug_see_also', 'class', - {TYPE => 'varchar(255)', NOTNULL => 1}); + {TYPE => 'varchar(255)', NOTNULL => 1, DEFAULT => "''"}); return; } -- cgit v1.2.3-24-g4f1b From 8c6f924b7872555617f861aad1e1184ce6e09dad Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 28 Feb 2012 09:22:03 +0100 Subject: Bug 731055: get_enterable_products() is very slow when a product has many components or versions r/a=mkanat --- Bugzilla/User.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 008322b17..391e416af 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -1040,12 +1040,14 @@ sub get_enterable_products { # And all of these products must have at least one component # and one version. $enterable_ids = $dbh->selectcol_arrayref( - 'SELECT DISTINCT products.id FROM products - INNER JOIN components ON components.product_id = products.id - INNER JOIN versions ON versions.product_id = products.id - WHERE products.id IN (' . join(',', @$enterable_ids) . ') - AND components.isactive = 1 - AND versions.isactive = 1'); + 'SELECT DISTINCT products.id FROM products + WHERE ' . $dbh->sql_in('products.id', $enterable_ids) . + ' AND products.id IN (SELECT DISTINCT components.product_id + FROM components + WHERE components.isactive = 1) + AND products.id IN (SELECT DISTINCT versions.product_id + FROM versions + WHERE versions.isactive = 1)'); } $self->{enterable_products} = -- cgit v1.2.3-24-g4f1b From d9a166a767592ea2f2647f9fca3e43d21f0cd4aa Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 28 Feb 2012 23:28:17 +0100 Subject: Bug 695514: Slow performance in field-events.js.tmpl on show_bug.cgi with large number of products r=dkl a=LpSolit --- template/en/default/bug/create/create.html.tmpl | 2 +- template/en/default/bug/field-events.js.tmpl | 12 +++++++++++- template/en/default/bug/field.html.tmpl | 3 ++- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/create/create.html.tmpl index 3fdf56472..f3dd680df 100644 --- a/template/en/default/bug/create/create.html.tmpl +++ b/template/en/default/bug/create/create.html.tmpl @@ -251,7 +251,7 @@ TUI_hide_default('attachment_text_field'); diff --git a/template/en/default/bug/field-events.js.tmpl b/template/en/default/bug/field-events.js.tmpl index 94dd298f5..13ec18d38 100644 --- a/template/en/default/bug/field-events.js.tmpl +++ b/template/en/default/bug/field-events.js.tmpl @@ -19,6 +19,8 @@ [%# INTERFACE: # field: a Bugzilla::Field object + # product: (optional) a Bugzilla::Product object. When specified, + # components are restricted to this product. #%] [% FOREACH controlled_field = field.controls_visibility_of %] @@ -29,7 +31,15 @@ [%- END %] ]); [% END %] -[% FOREACH legal_value = field.legal_values %] + +[% legal_values = [] %] +[% IF field.name == "component" AND product %] + [% legal_values = product.components %] +[% ELSE %] + [% legal_values = field.legal_values %] +[% END %] + +[% FOREACH legal_value = legal_values %] [% FOREACH controlled_field = legal_value.controlled_values.keys %] [% SET cont_ids = [] %] [% FOREACH val = legal_value.controlled_values.$controlled_field %] diff --git a/template/en/default/bug/field.html.tmpl b/template/en/default/bug/field.html.tmpl index 9c956ea91..681ea716d 100644 --- a/template/en/default/bug/field.html.tmpl +++ b/template/en/default/bug/field.html.tmpl @@ -149,7 +149,8 @@ -- cgit v1.2.3-24-g4f1b From bda60403ea62b195b678dff88387d9b392c7f4be Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Wed, 29 Feb 2012 12:51:35 +0800 Subject: Bug 731219: Fix XMLRPC breakage when content-type contains a charset r=dkl, a=LpSolit --- Bugzilla/WebService/Server/XMLRPC.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Bugzilla/WebService/Server/XMLRPC.pm b/Bugzilla/WebService/Server/XMLRPC.pm index 822709d85..025fb8f19 100644 --- a/Bugzilla/WebService/Server/XMLRPC.pm +++ b/Bugzilla/WebService/Server/XMLRPC.pm @@ -93,7 +93,10 @@ sub deserialize { my $self = shift; # Only allow certain content types to protect against CSRF attacks - if (!grep($_ eq $ENV{'CONTENT_TYPE'}, XMLRPC_CONTENT_TYPE_WHITELIST)) { + my $content_type = lc($ENV{'CONTENT_TYPE'}); + # Remove charset, etc, if provided + $content_type =~ s/^([^;]+);.*/$1/; + if (!grep($_ eq $content_type, XMLRPC_CONTENT_TYPE_WHITELIST)) { ThrowUserError('xmlrpc_illegal_content_type', { content_type => $ENV{'CONTENT_TYPE'} }); } -- cgit v1.2.3-24-g4f1b