From 167c501429dfd11bc598fa38bd8d49d8eb8c5878 Mon Sep 17 00:00:00 2001
From: David Lawrence <dkl@mozilla.com>
Date: Wed, 23 Mar 2016 23:05:01 +0000
Subject: Bug 1259266 - Attachment of security issues when viewing a bug are
 indistinguishable from any other attachment.

---
 extensions/BugModal/web/bug_modal.css         | 8 ++++++++
 skins/contrib/Mozilla/global.css              | 4 ++++
 template/en/default/attachment/list.html.tmpl | 6 +++---
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/extensions/BugModal/web/bug_modal.css b/extensions/BugModal/web/bug_modal.css
index 29a0f1c4e..8c5a4fcbc 100644
--- a/extensions/BugModal/web/bug_modal.css
+++ b/extensions/BugModal/web/bug_modal.css
@@ -432,6 +432,14 @@ input[type="number"] {
     background-image: linear-gradient(to right, #ffc, #fff);
 }
 
+#attachments .bz_private {
+    background: #fff;
+}
+
+#attachments .bz_private .attach-desc-td {
+    border-left: 4px solid darkred;
+}
+
 #attachments .vcard {
     display: inline;
 }
diff --git a/skins/contrib/Mozilla/global.css b/skins/contrib/Mozilla/global.css
index 755352c47..f51dd7ac8 100644
--- a/skins/contrib/Mozilla/global.css
+++ b/skins/contrib/Mozilla/global.css
@@ -495,6 +495,10 @@ table.edit_form hr {
     white-space: nowrap;
 }
 
+#attachment_table .bz_private .bz_attach_desc {
+    border-left: 4px solid darkred;
+}
+
 /* background for diff views */
 .file_table, .file-table {
     background: #ffffff;
diff --git a/template/en/default/attachment/list.html.tmpl b/template/en/default/attachment/list.html.tmpl
index 6309b7f0d..7a8abc8e1 100644
--- a/template/en/default/attachment/list.html.tmpl
+++ b/template/en/default/attachment/list.html.tmpl
@@ -36,7 +36,7 @@ function toggle_display(link) {
 
     if (YAHOO.util.Dom.hasClass(rows[0], 'bz_default_hidden')) {
         link.innerHTML = "Show Obsolete";
-        view_all.href = view_all.href + hide_obsolete_url_parameter 
+        view_all.href = view_all.href + hide_obsolete_url_parameter
     }
     else {
         link.innerHTML = "Hide Obsolete";
@@ -74,9 +74,9 @@ function toggle_display(link) {
                      FILTER css_class_quote %]
                  [% " bz_patch" IF attachment.can_review %]
                  [% " bz_private" IF attachment.isprivate %]
-                 [% " bz_tr_obsolete bz_default_hidden" 
+                 [% " bz_tr_obsolete bz_default_hidden"
                      IF attachment.isobsolete %]">
-        <td valign="top">
+        <td class="bz_attach_desc" valign="top">
           [% IF attachment.datasize %]
             <a href="attachment.cgi?id=[% attachment.id %]"
                title="View the content of the attachment">
-- 
cgit v1.2.3-24-g4f1b