From 345f9df2f29d90a777051db3d34194ac04b8b637 Mon Sep 17 00:00:00 2001 From: "jocuri%softhome.net" <> Date: Sat, 31 Jan 2004 08:12:08 +0000 Subject: Patch for bug 213679: Implement a parameter that allows administrators to control whether blank comments are allowed when filling new bugs; code by Dave Swegen ; r=myk; a=myk. --- defparams.pl | 8 ++++++++ post_bug.cgi | 4 ++++ template/en/default/global/user-error.html.tmpl | 4 ++++ 3 files changed, 16 insertions(+) diff --git a/defparams.pl b/defparams.pl index 640f92b97..e6cb16ac8 100644 --- a/defparams.pl +++ b/defparams.pl @@ -843,6 +843,14 @@ Reason: %reason% default => 'this may indicate a bug in your browser.' }, + { + name => 'commentoncreate', + desc => 'If this option is on, the user needs to enter a description ' . + 'when entering a new bug', + type => 'b', + default => 0 + }, + { name => 'commentonaccept', desc => 'If this option is on, the user needs to enter a short comment if ' . diff --git a/post_bug.cgi b/post_bug.cgi index 315ff3a99..dbc102d3e 100755 --- a/post_bug.cgi +++ b/post_bug.cgi @@ -76,6 +76,10 @@ my $format = GetFormat("bug/create/comment", $::FORM{'format'}, "txt"); $template->process($format->{'template'}, $vars, \$comment) || ThrowTemplateError($template->error()); +# Check that if required a description has been provided +if (Param("commentoncreate") && !trim($::FORM{'comment'})) { + ThrowUserError("description_required"); +} ValidateComment($comment); my $product = $::FORM{'product'}; diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index 1aec9b4f6..37eb7bd5b 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -150,6 +150,10 @@ [% title = "Dependency Loop Detected" %] You can't make [% terms.abug %] blocked or dependent on itself. + [% ELSIF error == "description_required" %] + [% title = "Description Required" %] + You must provide a description of the [% terms.bug %]. + [% ELSIF error == "dupe_invalid_bug_id" %] [% title = BLOCK %]Valid [% terms.Bug %] Number Required[% END %] You must specify a valid [% terms.bug %] number of which this -- cgit v1.2.3-24-g4f1b