From 40769a8b8f7db1b542b37776e8139d0f338bfbf7 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Sun, 13 Mar 2011 22:11:57 -0700 Subject: The mod_perl CGI.pm fix caused Bugzilla.pm to throw a warning on every invocation that didn't have $SIG{TERM} and $SIG{PIPE} set (for example, during command-line scripts). https://bugzilla.mozilla.org/show_bug.cgi?id=637977 --- Bugzilla.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Bugzilla.pm b/Bugzilla.pm index 9d7199ff6..2f657e3de 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -650,8 +650,9 @@ sub _cleanup { # These are both set by CGI.pm but need to be undone so that # Apache can actually shut down its children if it needs to. - $SIG{TERM} = 'DEFAULT' if $SIG{TERM} eq 'IGNORE'; - $SIG{PIPE} = 'DEFAULT' if $SIG{PIPE} eq 'IGNORE'; + foreach my $signal (qw(TERM PIPE)) { + $SIG{$signal} = 'DEFAULT' if $SIG{$signal} && $SIG{$signal} eq 'IGNORE'; + } } sub END { -- cgit v1.2.3-24-g4f1b