From 48649030bf8536d8b9cf9df522c39438a06ec56c Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Wed, 26 Aug 2015 23:36:17 +0200 Subject: Bug 1198659: Custom fields of type INTEGER should accept negative integers r=gerv a=sgreen --- Bugzilla/Bug.pm | 2 +- template/en/default/bug/field.html.tmpl | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index dda572ed7..bd3bf587c 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -2292,7 +2292,7 @@ sub _check_integer_field { ThrowUserError("number_not_integer", {field => $field, num => $orig_value}); } - elsif ($value > MAX_INT_32) { + elsif (abs($value) > MAX_INT_32) { ThrowUserError("number_too_large", {field => $field, num => $orig_value, max_num => MAX_INT_32}); } diff --git a/template/en/default/bug/field.html.tmpl b/template/en/default/bug/field.html.tmpl index 4d6019d01..87725b699 100644 --- a/template/en/default/bug/field.html.tmpl +++ b/template/en/default/bug/field.html.tmpl @@ -42,7 +42,10 @@ name="[% field.name FILTER html %]" value="[% value FILTER html %]" size="40" maxlength="[% constants.MAX_FREETEXT_LENGTH FILTER none %]" - [% IF field.type == constants.FIELD_TYPE_INTEGER %] pattern="\d+[% IF dontchange %]|[% dontchange FILTER html %][% END %]" [% END %] + [% IF field.type == constants.FIELD_TYPE_INTEGER %] + pattern="-?\d+[% IF dontchange %]|[% dontchange FILTER html %][% END %]" + title="The value must be a valid positive or negative integer" + [% END %] [% IF field.is_mandatory %] data-required="true" [% 'aria-required="true" required' UNLESS field_hidden %] [% END %]> -- cgit v1.2.3-24-g4f1b