From 5432b26b7479c9b90c1e172d285f02c00c173870 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Fri, 2 Sep 2005 04:52:20 +0000 Subject: Bug 298306: For new products, the charting error message "The tool which gathers bug counts has not been run yet" is misleading - Patch by Marc Schumann r=gerv a=myk --- reports.cgi | 6 +++++- template/en/default/global/code-error.html.tmpl | 14 ++++++++++++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/reports.cgi b/reports.cgi index 49948e2bb..7274ea8e2 100755 --- a/reports.cgi +++ b/reports.cgi @@ -253,7 +253,11 @@ sub generate_chart { my ($data_file, $image_file, $type, $product, $datasets) = @_; if (! open FILE, $data_file) { - ThrowCodeError("chart_data_not_generated"); + if ($product eq '-All-') { + $product = ''; + } + + ThrowCodeError("chart_data_not_generated", {'product' => $product}); } my @fields; diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl index f11b27b0a..b459fa44a 100644 --- a/template/en/default/global/code-error.html.tmpl +++ b/template/en/default/global/code-error.html.tmpl @@ -70,8 +70,18 @@ the error [% bug.error FILTER html %]. [% ELSIF error == "chart_data_not_generated" %] - The tool which gathers [% terms.bug %] counts has not been run yet. - + [% IF product %] + Charts for the [% product FILTER html %] product are not + available yet because no charting data has been collected for it since it + was created. + [% ELSE %] + No charting data has been collected yet. + [% END %] + Please wait a day and try again. + If you're seeing this message after a day, then you should contact + [% Param('maintainer') %] + and reference this error. + [% ELSIF error == "chart_datafile_corrupt" %] The chart data file [% file FILTER html %] is corrupt. -- cgit v1.2.3-24-g4f1b