From 5a15633a1179f960e1726eebf7f38c7ee2f2b4f8 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Sat, 28 Dec 2013 20:55:54 +0100 Subject: Bug 952795: Remove all style="..." attributes from HTML elements r/a=justdave --- skins/standard/admin.css | 40 +++++++++++ skins/standard/dependency-tree.css | 4 ++ skins/standard/editusers.css | 4 +- skins/standard/global.css | 38 ++++++++-- skins/standard/reports.css | 28 +++++++- skins/standard/summarize-time.css | 6 ++ template/en/default/admin/flag-type/edit.html.tmpl | 25 +++---- template/en/default/admin/params/common.html.tmpl | 4 +- template/en/default/admin/params/general.html.tmpl | 3 +- .../en/default/admin/products/updated.html.tmpl | 2 +- template/en/default/admin/table.html.tmpl | 4 +- template/en/default/admin/users/edit.html.tmpl | 2 +- template/en/default/attachment/diff-file.html.tmpl | 6 +- .../en/default/attachment/diff-header.html.tmpl | 22 ++++-- .../en/default/bug/create/create-guided.html.tmpl | 1 - template/en/default/bug/dependency-tree.html.tmpl | 29 +++----- template/en/default/bug/summarize-time.html.tmpl | 17 ++--- template/en/default/flag/list.html.tmpl | 4 +- template/en/default/global/textarea.html.tmpl | 2 - template/en/default/list/edit-multiple.html.tmpl | 21 +++--- template/en/default/list/server-push.html.tmpl | 2 +- template/en/default/list/table.html.tmpl | 4 +- template/en/default/reports/create-chart.html.tmpl | 48 ++++++------- template/en/default/reports/edit-series.html.tmpl | 4 +- .../en/default/reports/series-common.html.tmpl | 4 +- template/en/default/reports/series.html.tmpl | 44 ++++++------ .../default/search/search-create-series.html.tmpl | 2 +- template/en/default/whine/schedule.html.tmpl | 84 +++++++++------------- 28 files changed, 265 insertions(+), 189 deletions(-) diff --git a/skins/standard/admin.css b/skins/standard/admin.css index 7058bd1af..d0aaf368f 100644 --- a/skins/standard/admin.css +++ b/skins/standard/admin.css @@ -43,6 +43,20 @@ p.areyoureallyreallysure { font-weight: bold; } +#admin_table { + border-collapse: collapse; + border: 1px solid black; +} + +#admin_table th { + white-space: normal !important; +} + +#admin_table th, #admin_table td { + border: 1px solid black; + padding: 0.3em; +} + tr.disabled { background-color: lightgrey; } @@ -140,3 +154,29 @@ th.title { #flag_types_bugs .multiplicable, #flag_types_attachments .multiplicable { display: block; } + +table.whining_list { + border: 1px solid black; + border-collapse: collapse; + width: 100%; +} + +table.whining_list th, table.whining_list td { + padding: 0.3em; +} + +table.whining_list th { + text-align: right; + font-weight: normal !important; + white-space: normal !important; +} + +table.whining_list th.subtitle { + font-weight: bold !important; + text-align: left !important; +} + +table.schedule_list th, table.search_list th { + text-align: center; + font-weight: bold !important; +} diff --git a/skins/standard/dependency-tree.css b/skins/standard/dependency-tree.css index 0051fca36..efc2e8134 100644 --- a/skins/standard/dependency-tree.css +++ b/skins/standard/dependency-tree.css @@ -78,3 +78,7 @@ ul.tree a.tree_link img { color: #333; font-weight: bold; } + +.dependency_tree_controls input[type=submit] { + min-width: 3em; +} diff --git a/skins/standard/editusers.css b/skins/standard/editusers.css index fb38af67d..05cee4b39 100644 --- a/skins/standard/editusers.css +++ b/skins/standard/editusers.css @@ -34,12 +34,12 @@ table.groups tr.indirect { } table.groups th { text-align: left; - padding: 0 0 0 1ex; + padding: 0 1ex; } table.groups td { padding: 2px; } -table.groups td.checkbox { +table.groups th.checkbox, table.groups td.checkbox { text-align: center; white-space: nowrap; } diff --git a/skins/standard/global.css b/skins/standard/global.css index 9396a6346..ecf39c6a8 100644 --- a/skins/standard/global.css +++ b/skins/standard/global.css @@ -397,10 +397,6 @@ dl dl > dt { border-top: none; } -#admin_table th { - white-space: normal !important; -} - /* Arrow buttons are buttons with only ↑, ↓, ← or → on * them. We want these to look a little less spidery. */ .arrow_button { @@ -427,7 +423,7 @@ dl dl > dt { font-size: smaller; } -.bz_attach_flags, .bz_attach_footer { +.bz_attach_flags, .bz_attach_footer, .bz_flags, .nowrap { white-space: nowrap; } @@ -440,6 +436,10 @@ div.user_match { margin-bottom: 1em; } +.indented { + margin-left: 3em; +} + .box { border: 1px solid black; color: black; @@ -452,6 +452,12 @@ div.user_match { display: none; } +#serverpush_msg { + margin-top: 20%; + text-align: center; + font-size: xx-large; +} + /* Rules specific for printing */ @media print { #header, #footer { @@ -480,9 +486,14 @@ div.user_match { .field_help_link { cursor: help; } -.field_value, form#Create th, form#Create td { +.field_value, form#Create th, form#Create td, .top { vertical-align: top; } + +.bottom { + vertical-align: bottom; +} + .field_value .text_input { width: 100%; min-width: 25em; @@ -578,10 +589,23 @@ input.required, select.required, span.required_explanation { form th { text-align: right; } -th.left { + +.left { text-align: left; } +.center { + text-align: center; +} + +.right { + text-align: right; +} + +.inline { + display: inline; +} + tr.shared_search { background-color: #fff7cd; color: #000; diff --git a/skins/standard/reports.css b/skins/standard/reports.css index 8e0ddf1b0..4db7d2dac 100644 --- a/skins/standard/reports.css +++ b/skins/standard/reports.css @@ -106,4 +106,30 @@ .extra_info { font-size: smaller; font-style: italic; -} \ No newline at end of file +} + +#edit_series th, #create_chart th, #edit_charts th { + text-align: center; +} + +#edit_series th, #edit_series td, +#create_chart th, #create_chart td { + vertical-align: top; + padding: 0.5em; +} + +#edit_series select, #create_chart select { + width: 15em; +} + +#edit_series input { + width: 95%; +} + +#edit_series input#frequency { + width: 3em; +} + +#edit_charts input#action-sum, #edit_charts input#action-remove { + width: 7em; +} diff --git a/skins/standard/summarize-time.css b/skins/standard/summarize-time.css index bb42da6fe..c7ed96827 100644 --- a/skins/standard/summarize-time.css +++ b/skins/standard/summarize-time.css @@ -35,3 +35,9 @@ td.subtotal { /* the details headers */ .number .owner_header, .owner .bug_header { background: #ffffff } .number .owner_header2, .owner .bug_header2 { background: #EFEFEF } + +.warning_swapped_data { + border: 1px solid red; + margin: 1em; + padding: 0.5em; +} diff --git a/template/en/default/admin/flag-type/edit.html.tmpl b/template/en/default/admin/flag-type/edit.html.tmpl index 2e9771384..ec19c0496 100644 --- a/template/en/default/admin/flag-type/edit.html.tmpl +++ b/template/en/default/admin/flag-type/edit.html.tmpl @@ -23,10 +23,7 @@ [% PROCESS global/header.html.tmpl title = title - style = " - table#form th { text-align: right; vertical-align: baseline; white-space: nowrap; } - table#form td { text-align: left; vertical-align: baseline; } - " + style_urls = ['skins/standard/admin.css'] onload="var f = document.forms['flagtype_properties']; selectProduct(f.product, f.component, null, null, '__Any__');" javascript_urls=["js/productform.js"] @@ -49,7 +46,7 @@ [%# Add a hidden button at the top of the form so that the user pressing "return" # really submit the form, as expected. %] - + @@ -90,8 +87,8 @@ [% END %]
-
- Product/Component:
+ 		+ Product/Component:
- - 		- Inclusions:
+ + 		+ Inclusions:
[% PROCESS category_select name="inclusion_to_remove" categories = inclusions %]
- - 		- Exclusions:
+ + 		+ Exclusions:
[% PROCESS category_select name="exclusion_to_remove" categories = exclusions %]
- +
diff --git a/template/en/default/admin/params/common.html.tmpl b/template/en/default/admin/params/common.html.tmpl index 5f6f1bfc0..db3bde777 100644 --- a/template/en/default/admin/params/common.html.tmpl +++ b/template/en/default/admin/params/common.html.tmpl @@ -69,14 +69,14 @@ [% END %] - + - + diff --git a/template/en/default/admin/params/general.html.tmpl b/template/en/default/admin/params/general.html.tmpl index 369e495c7..9de306d1d 100644 --- a/template/en/default/admin/params/general.html.tmpl +++ b/template/en/default/admin/params/general.html.tmpl @@ -49,8 +49,7 @@ _ " green text inside a red box, or class=\"bz_private\" for" _ " dark red on a red background. Anything defined in " _ " skins/standard/global.css or skins/custom/global.css" - _ " will work. To get centered text, use style=\"text-align: " - _ " center;\".", + _ " will work. To get centered text, use class=\"center\".", upgrade_notification => "$terms.Bugzilla can inform you when a new release is available." diff --git a/template/en/default/admin/products/updated.html.tmpl b/template/en/default/admin/products/updated.html.tmpl index 4d2280163..cc0c9f8ea 100644 --- a/template/en/default/admin/products/updated.html.tmpl +++ b/template/en/default/admin/products/updated.html.tmpl @@ -39,7 +39,7 @@

Updated description to:

-

[% product.description FILTER html_light %]

+

[% product.description FILTER html_light %]

[% END %] [% IF changes.isactive.defined %] diff --git a/template/en/default/admin/table.html.tmpl b/template/en/default/admin/table.html.tmpl index b8492dcb2..3981ef4bb 100644 --- a/template/en/default/admin/table.html.tmpl +++ b/template/en/default/admin/table.html.tmpl @@ -67,11 +67,11 @@ [%################### TABLE HEADER ######################%] - +
[% FOREACH c = columns %] [%# Default to align left for headers %] - [% END %] diff --git a/template/en/default/admin/users/edit.html.tmpl b/template/en/default/admin/users/edit.html.tmpl index b75f8400d..e301ed21e 100644 --- a/template/en/default/admin/users/edit.html.tmpl +++ b/template/en/default/admin/users/edit.html.tmpl @@ -52,7 +52,7 @@ [% IF editusers %] - + [% END %] diff --git a/template/en/default/attachment/diff-file.html.tmpl b/template/en/default/attachment/diff-file.html.tmpl index 2c87188ad..1af6b3140 100644 --- a/template/en/default/attachment/diff-file.html.tmpl +++ b/template/en/default/attachment/diff-file.html.tmpl @@ -14,7 +14,11 @@ # considers the first row to determine column widths. If a colspan is found, # it then share the width equally among all columns, which we don't want. #%] -
+ [% c.heading FILTER html %]
||User is a member of these groups
[% collapsed ? '(+)' : '(-)' %] + [%# Hide/show resolved button Swaps text depending on the state of hide_resolved %] - diff --git a/template/en/default/bug/summarize-time.html.tmpl b/template/en/default/bug/summarize-time.html.tmpl index 932a6e3f4..ee654dc38 100644 --- a/template/en/default/bug/summarize-time.html.tmpl +++ b/template/en/default/bug/summarize-time.html.tmpl @@ -36,7 +36,7 @@ [%# parts contains date ranges (from, to). %] [% part = parts.shift %]
-

+

[% IF part.0 or part.1 %] [% part.0 OR "Up" FILTER html %] to [% part.1 OR "now" FILTER html %] [% ELSE %] @@ -52,7 +52,7 @@ [% END %] [% IF detailed %] -

+

Total of [% global.remaining FILTER format("%.2f") %]h remains from original estimate of [% global.estimated FILTER format("%.2f") %]h [% IF global.deadline %] @@ -62,13 +62,13 @@ [% END %] [% IF monthly %] -

Total of [% global.grand_total FILTER format("%.2f") %] hours worked

+

Total of [% global.grand_total FILTER format("%.2f") %] hours worked

[% END %] [% IF null.size > 0 %] [% INCLUDE inactive_report %] -

Total of [% null.size %] inactive [% terms.bugs %]

+

Total of [% null.size %] inactive [% terms.bugs %]

[% END %] [% END %] @@ -255,15 +255,16 @@ [% BLOCK query_form %]
-
+ [% IF warn_swap_dates %] -

The - end date specified occurs before the start date, which doesn't - make sense; the dates below have therefore been swapped.

+

+ The end date specified occurs before the start date, which doesn't + make sense; the dates below have therefore been swapped. +

[% END %]
[% collapsed ? '(+)' : '(-)' %] [% IF lxr_prefix && !file.is_add %] [% file.filename FILTER html %] [% ELSE %] diff --git a/template/en/default/attachment/diff-header.html.tmpl b/template/en/default/attachment/diff-header.html.tmpl index 4261c8423..b8b0d2cc0 100644 --- a/template/en/default/attachment/diff-header.html.tmpl +++ b/template/en/default/attachment/diff-header.html.tmpl @@ -43,7 +43,9 @@ Interdiff of #[% oldid %] and #[% newid %] for [% terms.bug %] #[% bugid %] [% ELSE %] - + @@ -57,13 +59,15 @@ Interdiff of #[% oldid %] and #[% newid %] for [% terms.bug %] #[% bugid %] [% IF headers %] View | Details - | Raw Unified + | Raw Unified | Return to [% "$terms.bug $bugid" FILTER bug_link(bugid) FILTER none %] [% END %] [% IF other_patches.size > 0 %] [% IF headers %] |[%END%] Differences between -
+
) +
+ + + + + +
) [% END %] [% IF warning %] @@ -139,4 +149,4 @@ Interdiff of #[% oldid %] and #[% newid %] for [% terms.bug %] #[% bugid %] [%# Restore Stuff %]
- + diff --git a/template/en/default/bug/create/create-guided.html.tmpl b/template/en/default/bug/create/create-guided.html.tmpl index 181b76e62..7abb8c7dc 100644 --- a/template/en/default/bug/create/create-guided.html.tmpl +++ b/template/en/default/bug/create/create-guided.html.tmpl @@ -62,7 +62,6 @@ function PutDescription() {

diff --git a/template/en/default/bug/dependency-tree.html.tmpl b/template/en/default/bug/dependency-tree.html.tmpl index 369326d48..61994cf28 100644 --- a/template/en/default/bug/dependency-tree.html.tmpl +++ b/template/en/default/bug/dependency-tree.html.tmpl @@ -166,9 +166,8 @@
- + + [% IF maxdepth %] @@ -188,11 +187,9 @@ - + [%# set to one form %] - @@ -201,8 +198,7 @@ - + [%# Minus one form Allow subtracting only when realdepth and maxdepth > 1 %] @@ -211,14 +207,13 @@ : ( maxdepth ? maxdepth - 1 : realdepth - 1 ) %]"> - -
+ [%# Limit entry form: the button cannot do anything when total depth is less than two, so disable it %] + [%# plus one form Disable button if total depth < 2, or if depth set to unlimited %] @@ -243,19 +237,18 @@ [% END %] - = realdepth %]>
-
+ [%# Unlimited button %]
diff --git a/template/en/default/flag/list.html.tmpl b/template/en/default/flag/list.html.tmpl index 4d7eefb48..8acef5631 100644 --- a/template/en/default/flag/list.html.tmpl +++ b/template/en/default/flag/list.html.tmpl @@ -132,9 +132,8 @@ [% IF any_flags_requesteeble %] - [% END %] diff --git a/template/en/default/global/textarea.html.tmpl b/template/en/default/global/textarea.html.tmpl index 216f2ddbf..bc5fd6311 100644 --- a/template/en/default/global/textarea.html.tmpl +++ b/template/en/default/global/textarea.html.tmpl @@ -11,7 +11,6 @@ # id: (optional) The "id"-attribute of the textarea. # name: (optional) The "name"-attribute of the textarea. # accesskey: (optional) The "accesskey"-attribute of the textarea. - # style: (optional) The "style"-attribute of the textarea. # classes: (optional) The "class"-attribute of the textarea. # wrap: (deprecated; optional) The "wrap"-attribute of the textarea. # disabled: (optional) Disable the textarea. @@ -33,7 +32,6 @@
+ [% IF (type.is_active && type.is_requestable && type.is_requesteeble) || (flag && flag.requestee) %] - [% SET grant_list = [] %] [% IF Param('usemenuforusers') %] [% grant_list = type.grant_list %] @@ -158,7 +157,6 @@ classes => ["requestee"] custom_userlist => grant_list %] - [% END %]