From 6f323ff54643622bcd31f6b7577ab1a23d16f590 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Wed, 28 Dec 2011 17:03:56 -0500 Subject: Bug 697699 - (CVE-2011-3657) [SECURITY] XSS when viewing new charts or tabular and graphical reports in debug mode r=gerv, a=LpSolit --- Bugzilla/Chart.pm | 2 +- report.cgi | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Bugzilla/Chart.pm b/Bugzilla/Chart.pm index 760db135d..dfbf32a51 100644 --- a/Bugzilla/Chart.pm +++ b/Bugzilla/Chart.pm @@ -438,7 +438,7 @@ sub dump { require Data::Dumper; print "
Bugzilla::Chart object:\n";
-    print Data::Dumper::Dumper($self);
+    print html_quote(Data::Dumper::Dumper($self));
     print "
"; } diff --git a/report.cgi b/report.cgi index a71776bfe..dccc470a7 100755 --- a/report.cgi +++ b/report.cgi @@ -288,9 +288,9 @@ print $cgi->header(-type => $format->{'ctype'}, if ($cgi->param('debug')) { require Data::Dumper; print "
data hash:\n";
-    print Data::Dumper::Dumper(%data) . "\n\n";
+    print html_quote(Data::Dumper::Dumper(%data)) . "\n\n";
     print "data array:\n";
-    print Data::Dumper::Dumper(@image_data) . "\n\n
"; + print html_quote(Data::Dumper::Dumper(@image_data)) . "\n\n"; } # All formats point to the same section of the documentation. -- cgit v1.2.3-24-g4f1b