From 739d3a205aa7e3da1525eb8cce2ee7ef46317702 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Sun, 13 Feb 2011 23:41:25 -0800 Subject: Bug 633422: Fix the documentation for User.get's include_disabled parameter and make User.get check that its required parameters are passed. r=LpSolit, a=mkanat --- Bugzilla/WebService/User.pm | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm index 4b11611e1..9f118d4a6 100644 --- a/Bugzilla/WebService/User.pm +++ b/Bugzilla/WebService/User.pm @@ -138,6 +138,11 @@ sub create { sub get { my ($self, $params) = validate(@_, 'names', 'ids'); + defined($params->{names}) || defined($params->{ids}) + || defined($params->{match}) + || ThrowCodeError('params_required', + { function => 'User.get', params => ['ids', 'names', 'match'] }); + my @user_objects; @user_objects = map { Bugzilla::User->check($_) } @{ $params->{names} } if $params->{names}; @@ -535,8 +540,10 @@ in I of the groups specified. =item C (boolean) By default, when using the C parameter, disabled users are excluded -from the returned results. Setting C to C will include -any users that are set to disabled in the returned results. +from the returned results unless their full username is identical to the +match string. Setting C to C will include disabled +users in the returned results even if their username doesn't fully match +the input string. =back -- cgit v1.2.3-24-g4f1b