From 80e66f4380525ec512995544fc13e01e88b55344 Mon Sep 17 00:00:00 2001 From: "terry%mozilla.org" <> Date: Fri, 24 Sep 1999 02:19:01 +0000 Subject: Patch by holger@holger.om.org (Holger Schurig) -- several cleanups. --- CGI.pl | 6 ++---- buglist.cgi | 3 +-- query.cgi | 2 +- reports.cgi | 3 +++ 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CGI.pl b/CGI.pl index c12ce8e5e..0d9762b22 100644 --- a/CGI.pl +++ b/CGI.pl @@ -29,11 +29,9 @@ require 'globals.pl'; sub GeneratePersonInput { my ($field, $required, $def_value, $extraJavaScript) = (@_); - if (!defined $extraJavaScript) { - $extraJavaScript = ""; - } + $extraJavaScript ||= ""; if ($extraJavaScript ne "") { - $extraJavaScript = "onChange=\" $extraJavaScript \""; + $extraJavaScript = "onChange=\"$extraJavaScript\""; } return ""; } diff --git a/buglist.cgi b/buglist.cgi index ee4aa39fd..8d3182200 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -546,14 +546,13 @@ while (@row = FetchSQLData()) { next; } my $value = shift @row; - my $nowrap = ""; if ($::needquote{$c}) { $value = html_quote($value); } else { $value = "$value"; } - pnl "$value"; + pnl "$value"; } if ($dotweak) { my $value = shift @row; diff --git a/query.cgi b/query.cgi index bee45e9f4..5f8d36214 100755 --- a/query.cgi +++ b/query.cgi @@ -57,7 +57,7 @@ if (!defined $::buffer || $::buffer eq "") { $::buffer = $::COOKIE{"DEFAULTQUERY"}; } -my %default; +use vars qw(%default); my %type; foreach my $name ("bug_status", "resolution", "assigned_to", "rep_platform", diff --git a/reports.cgi b/reports.cgi index c7a22fcd3..21cfd780e 100755 --- a/reports.cgi +++ b/reports.cgi @@ -261,6 +261,9 @@ FIN # start painting report # ######################### + $bugs_status{'NEW'} ||= '0'; + $bugs_status{'ASSIGNED'} ||= '0'; + $bugs_status{'REOPENED'} ||= '0'; print <$quip -- cgit v1.2.3-24-g4f1b