From a46cf131f0248614b048f55b30b1b92304292f01 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Sat, 2 Oct 2010 12:23:38 -0700 Subject: Bug 600495: Make searching using "chfieldto" actually work again, for finding bugs that were also updated after the particular change that's being looked for. r=mkanat, a=mkanat (module owner) --- Bugzilla/Search.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index fa162ed1d..fa1e40131 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -1289,16 +1289,17 @@ sub _special_parse_chfield { my @charts; # It is always safe and useful to push delta_ts into the charts - # if there are any dates specified. It doesn't conflict with + # if there is a "from" date specified. It doesn't conflict with # searching [Bug creation], because a bug's delta_ts is set to # its creation_ts when it is created. So this just gives the # database an additional index to possibly choose. + # + # It's not safe to do it for "to" dates, though--"chfieldto" means + # "a field that changed before this date", and delta_ts could be either + # later or earlier than that. if ($date_from ne '') { push(@charts, ['delta_ts', 'greaterthaneq', $date_from]); } - if ($date_to ne '') { - push(@charts, ['delta_ts', 'lessthaneq', $date_to]); - } # Basically, we construct the chart like: # -- cgit v1.2.3-24-g4f1b