From a5b780358d0e8c9cd611a644b3d6168daac711e3 Mon Sep 17 00:00:00 2001 From: dklawren Date: Fri, 11 May 2018 12:13:35 -0400 Subject: Bug 1460466 - Phab bot does not create r+ for acceptance when there are still blocking reviewers --- extensions/PhabBugz/lib/Feed.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm index 821ec6527..a0012cc10 100644 --- a/extensions/PhabBugz/lib/Feed.pm +++ b/extensions/PhabBugz/lib/Feed.pm @@ -412,11 +412,9 @@ sub process_revision_change { # REVIEWER STATUSES my (@accepted_phids, @denied_phids, @accepted_user_ids, @denied_user_ids); - unless ($revision->status eq 'changes-planned' || $revision->status eq 'needs-review') { - foreach my $reviewer (@{ $revision->reviewers }) { - push(@accepted_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'accepted'; - push(@denied_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'rejected'; - } + foreach my $reviewer (@{ $revision->reviewers }) { + push(@accepted_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'accepted'; + push(@denied_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'rejected'; } my $phab_users = get_phab_bmo_ids({ phids => \@accepted_phids }); -- cgit v1.2.3-24-g4f1b