From aa7b4750a7c84e2807cdaa66d304fa42615a6f6e Mon Sep 17 00:00:00 2001 From: "jake%acutex.net" <> Date: Tue, 19 Jun 2001 09:05:08 +0000 Subject: Running a query using the Added Comment option was very slow (bug 57350). Patch by Myk Melez and Dave Miller r= jake@acutex.net --- buglist.cgi | 4 ++-- checksetup.pl | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/buglist.cgi b/buglist.cgi index b99afefe9..206b968ca 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -241,7 +241,7 @@ sub GenerateSQL { push(@wherepart, "$table.bug_id = bugs.bug_id"); my $ptable = "longdescnames_"; push(@supptables, - "LEFT JOIN profiles $ptable ON $table.who = $ptable.userid"); + "INNER JOIN profiles $ptable ON $table.who = $ptable.userid"); push(@clist, "$ptable.login_name", $type, $email); } if (@clist) { @@ -745,7 +745,7 @@ sub GenerateSQL { my $suppstring = "bugs"; foreach my $str (@supptables) { if (!$suppseen{$str}) { - if ($str !~ /^LEFT JOIN/i) { + if ($str !~ /^(LEFT|INNER) JOIN/i) { $suppstring .= ","; } $suppstring .= " $str"; diff --git a/checksetup.pl b/checksetup.pl index ed90b6f5d..f8ef65d77 100755 --- a/checksetup.pl +++ b/checksetup.pl @@ -761,6 +761,7 @@ $table{longdescs} = thetext mediumtext, index(bug_id), + index(who), index(bug_when)'; @@ -2184,6 +2185,16 @@ if (-d 'shadow') { DropField("profiles", "emailnotification"); DropField("profiles", "newemailtech"); +# +# 2001-06-06 justdave@syndicomm.com: +# There was no index on the 'who' column in the long descriptions table. +# This caused queries by who posted comments to take a LONG time. +# http://bugzilla.mozilla.org/show_bug.cgi?id=57350 +if (!defined GetIndexDef('longdescs','who')) { + print "Adding index for who column in longdescs table...\n"; + $dbh->do('ALTER TABLE longdescs ADD INDEX (who)'); +} + # 2001-06-15 kiko@async.com.br - Change bug:version size to avoid # truncates re http://bugzilla.mozilla.org/show_bug.cgi?id=9352 ChangeFieldType('bugs', 'version','varchar(64) not null'); -- cgit v1.2.3-24-g4f1b