From ac99ed7df8d80945ab7860dad022fb5d372ff02d Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Wed, 6 Aug 2008 02:54:00 +0000 Subject: Bug 449248: Improve $product->group_controls - Patch by Frédéric Buclin r/a=mkanat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Product.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm index f5c4fae6c..e0a265b69 100644 --- a/Bugzilla/Product.pm +++ b/Bugzilla/Product.pm @@ -509,10 +509,11 @@ sub group_controls { ORDER BY groups.name}; $self->{group_controls} = $dbh->selectall_hashref($query, 'id', undef, $self->id); - foreach my $group (keys(%{$self->{group_controls}})) { - $self->{group_controls}->{$group}->{'group'} = - new Bugzilla::Group($group); - } + + # For each group ID listed above, create and store its group object. + my @gids = keys %{$self->{group_controls}}; + my $groups = Bugzilla::Group->new_from_list(\@gids); + $self->{group_controls}->{$_->id}->{group} = $_ foreach @$groups; } return $self->{group_controls}; } -- cgit v1.2.3-24-g4f1b