From b0df54c7f19387f72124b53431473374db26c0cf Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Mon, 5 May 2014 15:15:18 +0800 Subject: Bug 999331: searching attachment data is very slow due to an unbounded select r=LpSolit, a=glob --- Bugzilla/Search.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index 1c008bdfb..75a0fbdb4 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -2053,6 +2053,13 @@ sub _quote_unless_numeric { sub build_subselect { my ($outer, $inner, $table, $cond, $negate) = @_; + if ($table =~ /\battach_data\b/) { + # It takes a long time to scan the whole attach_data table + # unconditionally, so we return the subselect and let the DB optimizer + # restrict the search based on other search criteria. + my $not = $negate ? "NOT" : ""; + return "$outer $not IN (SELECT DISTINCT $inner FROM $table WHERE $cond)"; + } # Execute subselects immediately to avoid dependent subqueries, which are # large performance hits on MySql my $q = "SELECT DISTINCT $inner FROM $table WHERE $cond"; -- cgit v1.2.3-24-g4f1b