From b26634d776066be7e6e358bfff0bad4a25a27d51 Mon Sep 17 00:00:00 2001 From: "bugreport%peshkin.net" <> Date: Sat, 8 Oct 2005 11:58:54 +0000 Subject: Bug 28398 Gotta be more careful when emailing state changes of dependent bugs Patch by André Batosti r=lpsolit, a=justdave MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- process_bug.cgi | 6 +++--- template/en/default/bug/process/bugmail.html.tmpl | 12 ++++++++---- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/process_bug.cgi b/process_bug.cgi index e98005a9c..af3ebc977 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -1914,9 +1914,9 @@ foreach my $id (@idlist) { $vars->{'id'} = $k; $vars->{'type'} = "dep"; - # Let the user know we checked to see if we should email notice - # of this change to users with a relationship to the dependent - # bug and who did and didn't receive email about it. + # Let the user (if he is able to see the bug) know we checked to see + # if we should email notice of this change to users with a relationship + # to the dependent bug and who did and didn't receive email about it. $template->process("bug/process/results.html.tmpl", $vars) || ThrowTemplateError($template->error()); $vars->{'header_done'} = 1; diff --git a/template/en/default/bug/process/bugmail.html.tmpl b/template/en/default/bug/process/bugmail.html.tmpl index a2a6e7353..a5d20e78d 100644 --- a/template/en/default/bug/process/bugmail.html.tmpl +++ b/template/en/default/bug/process/bugmail.html.tmpl @@ -62,11 +62,15 @@ [% BLOCK emails %] [% description FILTER html %]: - [% IF names.size > 0 %] - [%+ FOREACH name = names %] - [% name FILTER html %][% ", " UNLESS loop.last() %] + [% IF user.can_see_bug(mailing_bugid) %] + [% IF names.size > 0 %] + [%+ FOREACH name = names %] + [% name FILTER html %][% ", " UNLESS loop.last() %] + [% END %] + [% ELSE %] + no one [% END %] [% ELSE %] - no one + (list of e-mails not avaliable) [% END %] [% END %] -- cgit v1.2.3-24-g4f1b