From b446f4e4e5db1300c8ee9edea900c8e3456e8d1f Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Thu, 3 Jul 2008 00:10:17 +0000 Subject: Bug 442821: Make the workflow editor deny closed statuses for new bugs Patch By Max Kanat-Alexander r=LpSolit, a=LpSolit --- editworkflow.cgi | 2 +- template/en/default/admin/workflow/edit.html.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/editworkflow.cgi b/editworkflow.cgi index eddf845f2..7e51798fc 100644 --- a/editworkflow.cgi +++ b/editworkflow.cgi @@ -87,7 +87,7 @@ elsif ($action eq 'update') { # Part 1: Initial bug statuses. foreach my $new (@$statuses) { - if ($cgi->param('w_0_' . $new->id)) { + if ($new->is_open && $cgi->param('w_0_' . $new->id)) { $sth_insert->execute(undef, $new->id) unless defined $workflow->{0}->{$new->id}; } diff --git a/template/en/default/admin/workflow/edit.html.tmpl b/template/en/default/admin/workflow/edit.html.tmpl index 5ae2cef2a..516d184b9 100644 --- a/template/en/default/admin/workflow/edit.html.tmpl +++ b/template/en/default/admin/workflow/edit.html.tmpl @@ -67,7 +67,7 @@ [% FOREACH new_status = statuses %] - [% IF status.id != new_status.id %] + [% IF status.id != new_status.id && (status.id || new_status.is_open) %] [% checked = workflow.${status.id}.${new_status.id}.defined ? 1 : 0 %] [% mandatory = (status.id && new_status.name == Param("duplicate_or_move_bug_status")) ? 1 : 0 %]