From b8fcea9b7c6cdb15bc8cb65500e42f78a0f7d4f0 Mon Sep 17 00:00:00 2001 From: Alex Schuilenburg Date: Thu, 14 Mar 2013 16:51:07 -0400 Subject: Bug 525195 - Invisible fields still show up in the "New:" bugmail (fields whose visibility depends on another field) r=dkl,a=LpSolit --- Bugzilla/BugMail.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm index 1fb5ea977..089d3013e 100644 --- a/Bugzilla/BugMail.pm +++ b/Bugzilla/BugMail.pm @@ -443,11 +443,18 @@ sub _get_new_bugmail_fields { my $bug = shift; my @fields = @{ Bugzilla->fields({obsolete => 0, in_new_bugmail => 1}) }; my @diffs; + my $params = Bugzilla->params; foreach my $field (@fields) { my $name = $field->name; my $value = $bug->$name; + next if !$field->is_visible_on_bug($bug) + || ($name eq 'classification' && !$params->{'useclassification'}) + || ($name eq 'status_whiteboard' && !$params->{'usestatuswhiteboard'}) + || ($name eq 'qa_contact' && !$params->{'useqacontact'}) + || ($name eq 'target_milestone' && !$params->{'usetargetmilestone'}); + if (ref $value eq 'ARRAY') { $value = join(', ', @$value); } -- cgit v1.2.3-24-g4f1b