From b9022b0d22f4f20815dfc946fd784a0db64fdc3c Mon Sep 17 00:00:00 2001
From: Frédéric Buclin <LpSolit@gmail.com>
Date: Sat, 20 Feb 2010 16:21:25 +0100
Subject: Bug 373278: Add distinctive marking for security bugs in request.cgi
 r=pyrzak a=LpSolit

---
 request.cgi                                 | 7 +++++--
 skins/standard/buglist.css                  | 4 ++--
 template/en/default/request/queue.html.tmpl | 4 +++-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/request.cgi b/request.cgi
index b54477cb1..e1137b3f2 100755
--- a/request.cgi
+++ b/request.cgi
@@ -113,7 +113,7 @@ sub queue {
                 products.name, components.name,
                 flags.attach_id, attachments.description,
                 requesters.realname, requesters.login_name,
-                requestees.realname, requestees.login_name,
+                requestees.realname, requestees.login_name, COUNT(privs.group_id),
     " . $dbh->sql_date_format('flags.modification_date', '%Y.%m.%d %H:%i') .
     # Use the flags and flagtypes tables for information about the flags,
     # the bugs and attachments tables for target info, the profiles tables
@@ -141,6 +141,8 @@ sub queue {
                   ON bgmap.bug_id = bugs.bug_id
                  AND bgmap.group_id NOT IN (" .
                      $user->groups_as_string . ")
+           LEFT JOIN bug_group_map AS privs
+                  ON privs.bug_id = bugs.bug_id
            LEFT JOIN cc AS ccmap
                   ON ccmap.who = $userid
                  AND ccmap.bug_id = bugs.bug_id
@@ -292,7 +294,8 @@ sub queue {
           'attach_summary'  => $data[8] ,
           'requester'       => ($data[9] ? "$data[9] <$data[10]>" : $data[10]) , 
           'requestee'       => ($data[11] ? "$data[11] <$data[12]>" : $data[12]) , 
-          'created'         => $data[13]
+          'restricted'      => $data[13] ? 1 : 0,
+          'created'         => $data[14]
         };
         push(@requests, $request);
     }
diff --git a/skins/standard/buglist.css b/skins/standard/buglist.css
index 00614a6cf..039c1e56e 100644
--- a/skins/standard/buglist.css
+++ b/skins/standard/buglist.css
@@ -59,14 +59,14 @@ table.bz_buglist td, table.bz_buglist th {
 
 /* we use a first-child class and not the pseudo-class because IE
  * doesn't support it :-( */
-tr.bz_secure td.first-child { 
+tr.bz_secure td.first-child, a.bz_secure { 
   background-image: url("../../images/padlock.png");
   background-position: center left;
   background-repeat: no-repeat;
   background-color: inherit;
 }
 
-th.first-child, td.first-child {
+th.first-child, td.first-child, a.bz_secure {
   padding-left: 20px;
 }
 
diff --git a/template/en/default/request/queue.html.tmpl b/template/en/default/request/queue.html.tmpl
index 98a331622..2d1769b96 100644
--- a/template/en/default/request/queue.html.tmpl
+++ b/template/en/default/request/queue.html.tmpl
@@ -31,6 +31,7 @@
   "
   onload="var f = document.request_form; selectProduct(f.product, f.component, null, null, 'Any');"
   javascript_urls=["js/productform.js"]
+  style_urls = ['skins/standard/buglist.css']
 %]
 
 <script type="text/javascript">
@@ -214,7 +215,8 @@ to some group are shown by default.
 [% END %]
 
 [% BLOCK display_bug %]
-  <a href="show_bug.cgi?id=[% request.bug_id %]">
+  <a href="show_bug.cgi?id=[% request.bug_id %]"
+     [%- ' class="bz_secure"' IF request.restricted %]>
     [% request.bug_id %]: [%+ request.bug_summary FILTER html %]</a>
 [% END %]
 
-- 
cgit v1.2.3-24-g4f1b