From c664718ef5e857144479859546d998f1465b830b Mon Sep 17 00:00:00 2001 From: Dylan Hardison Date: Fri, 26 Feb 2016 08:56:16 -0500 Subject: Bug 1251221 - Pass cache => 1 to calls to Bugzilla::Product->new() called in Bugzilla::{Milestone,Version,Component} r=dkl,a=dylan --- Bugzilla/Component.pm | 7 +++---- Bugzilla/Milestone.pm | 2 +- Bugzilla/Version.pm | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Bugzilla/Component.pm b/Bugzilla/Component.pm index 9bc0a4493..3e50dab80 100644 --- a/Bugzilla/Component.pm +++ b/Bugzilla/Component.pm @@ -390,10 +390,9 @@ sub initial_cc { sub product { my $self = shift; - if (!defined $self->{'product'}) { - require Bugzilla::Product; # We cannot |use| it. - $self->{'product'} = new Bugzilla::Product($self->product_id); - } + + require Bugzilla::Product; + $self->{'product'} ||= Bugzilla::Product->new({ id => $self->product_id, cache => 1 }); return $self->{'product'}; } diff --git a/Bugzilla/Milestone.pm b/Bugzilla/Milestone.pm index cf7e3e35f..9cee52248 100644 --- a/Bugzilla/Milestone.pm +++ b/Bugzilla/Milestone.pm @@ -236,7 +236,7 @@ sub product { my $self = shift; require Bugzilla::Product; - $self->{'product'} ||= new Bugzilla::Product($self->product_id); + $self->{'product'} ||= Bugzilla::Product->new({ id => $self->product_id, cache => 1 }); return $self->{'product'}; } diff --git a/Bugzilla/Version.pm b/Bugzilla/Version.pm index 4b332ff2b..f6fedeba7 100644 --- a/Bugzilla/Version.pm +++ b/Bugzilla/Version.pm @@ -167,7 +167,7 @@ sub product { my $self = shift; require Bugzilla::Product; - $self->{'product'} ||= new Bugzilla::Product($self->product_id); + $self->{'product'} ||= Bugzilla::Product->new({ id => $self->product_id, cache => 1 }); return $self->{'product'}; } -- cgit v1.2.3-24-g4f1b