From cce2c9c109e147b448034a7d1398b228df5b9953 Mon Sep 17 00:00:00 2001 From: "bbaetz%student.usyd.edu.au" <> Date: Tue, 9 Jul 2002 08:17:14 +0000 Subject: Bug 151714 - user with no canconfirm permission should not get option to mark bugs they reported as NEW r=jouni, myk --- bug_form.pl | 6 ++++-- template/en/default/bug/edit.html.tmpl | 8 ++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/bug_form.pl b/bug_form.pl index 406d86c40..db09d8d58 100644 --- a/bug_form.pl +++ b/bug_form.pl @@ -274,8 +274,10 @@ sub show_bug { || $::userid == $bug{'reporter'} || $::userid == $bug{'qa_contact'} || $::userid == $bug{'assigned_to'} - || UserInGroup("editbugs"); - $user{'canconfirm'} = ($::userid == 0) || UserInGroup("canconfirm"); + || UserInGroup("editbugs"); + $user{'canconfirm'} = ($::userid == 0) + || UserInGroup("canconfirm") + || UserInGroup("editbugs"); # Bug states $bug{'isunconfirmed'} = ($bug{'bug_status'} eq $::unconfirmedstate); diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl index 83972baae..e0ecf2623 100644 --- a/template/en/default/bug/edit.html.tmpl +++ b/template/en/default/bug/edit.html.tmpl @@ -371,7 +371,7 @@ [% knum = 1 %] [% IF bug.bug_status == "UNCONFIRMED" && - (user.canedit || user.canconfirm) %] + user.canconfirm %] Confirm bug (change status to NEW)
@@ -380,7 +380,7 @@ [% IF user.canedit %] [% IF bug.isopened %] - [% IF bug.bug_status != "ASSIGNED" %] + [% IF bug.bug_status != "ASSIGNED" && user.canconfirm %] Accept bug ( [% "confirm bug, " IF bug.isunconfirmed %]change @@ -424,7 +424,7 @@ }" value="[% bug.assigned_to_email FILTER html %]">
- [% IF bug.isunconfirmed %] + [% IF bug.isunconfirmed && user.canconfirm %]      and confirm bug (change status to NEW)
@@ -436,7 +436,7 @@ [% "and QA contact" IF useqacontact %] of selected component
- [% IF bug.isunconfirmed %] + [% IF bug.isunconfirmed && user.canconfirm %]      and confirm bug (change status to NEW)
-- cgit v1.2.3-24-g4f1b