From cec56973dd19c6b949d549d30d4375b76de50e27 Mon Sep 17 00:00:00 2001
From: "lpsolit%gmail.com" <>
Date: Thu, 9 Apr 2009 21:49:04 +0000
Subject: Fix a warning thrown in the web server error log (due to bug 454251)

---
 Bugzilla/Attachment.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm
index 33c761cf1..9748d17f4 100644
--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -613,12 +613,13 @@ sub _check_filename {
 sub _check_is_private {
     my ($invocant, $is_private) = @_;
 
+    $is_private = $is_private ? 1 : 0;
     if (((!ref $invocant && $is_private)
          || (ref $invocant && $invocant->isprivate != $is_private))
         && !Bugzilla->user->is_insider) {
         ThrowUserError('user_not_insider');
     }
-    return $is_private ? 1 : 0;
+    return $is_private;
 }
 
 sub _check_is_url {
-- 
cgit v1.2.3-24-g4f1b