From d56069c56d0adec39a815e7592ac868dc847afb1 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 18 Jul 2011 02:27:25 +0200 Subject: Bug 670128: Missing explicit exit after calls to $cgi->redirect(), making the rest of the scripts to be executed r=dkl a=LpSolit --- post_bug.cgi | 5 ++++- relogin.cgi | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/post_bug.cgi b/post_bug.cgi index e6b77f8ea..6d6ed746c 100755 --- a/post_bug.cgi +++ b/post_bug.cgi @@ -55,7 +55,10 @@ my $vars = {}; ###################################################################### # redirect to enter_bug if no field is passed. -print $cgi->redirect(correct_urlbase() . 'enter_bug.cgi') unless $cgi->param(); +unless ($cgi->param()) { + print $cgi->redirect(correct_urlbase() . 'enter_bug.cgi'); + exit; +} # Detect if the user already used the same form to submit a bug my $token = trim($cgi->param('token')); diff --git a/relogin.cgi b/relogin.cgi index 028f4ddb1..f6a410c05 100755 --- a/relogin.cgi +++ b/relogin.cgi @@ -45,6 +45,7 @@ my $target; if (!$action) { # redirect to index.cgi if no action is defined. print $cgi->redirect(correct_urlbase() . 'index.cgi'); + exit; } # prepare-sudo: Display the sudo information & login page elsif ($action eq 'prepare-sudo') { -- cgit v1.2.3-24-g4f1b