From fb2f6bd8ca4ed8879f82a2764d63d51a06670477 Mon Sep 17 00:00:00 2001 From: Matt Selsky Date: Thu, 26 Apr 2012 13:42:55 +0200 Subject: Bug 747189: Remove Bugzilla::Util::file_mod_time() r/a=LpSolit --- Bugzilla/Util.pm | 26 +------------------------- showdependencygraph.cgi | 2 +- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm index 097fc49fe..9e2e1fecd 100644 --- a/Bugzilla/Util.pm +++ b/Bugzilla/Util.pm @@ -18,8 +18,7 @@ use base qw(Exporter); diff_arrays on_main_db say trim wrap_hard wrap_comment find_wrap_point format_time validate_date validate_time datetime_from - file_mod_time is_7bit_clean - bz_crypt generate_random_password + is_7bit_clean bz_crypt generate_random_password validate_email_syntax check_email_syntax clean_text get_text template_var disable_utf8 detect_encoding); @@ -560,14 +559,6 @@ sub datetime_from { return $dt; } -sub file_mod_time { - my ($filename) = (@_); - my ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size, - $atime,$mtime,$ctime,$blksize,$blocks) - = stat($filename); - return $mtime; -} - sub bz_crypt { my ($password, $salt) = @_; @@ -849,9 +840,6 @@ Bugzilla::Util - Generic utility functions for bugzilla format_time($time); datetime_from($time, $timezone); - # Functions for dealing with files - $time = file_mod_time($filename); - # Cryptographic Functions $crypted_password = bz_crypt($password); $new_password = generate_random_password($password_length); @@ -1119,18 +1107,6 @@ the Bugzilla server's local timezone if there isn't a logged-in user. =back - -=head2 Files - -=over 4 - -=item C - -Takes a filename and returns the modification time. It returns it in the format -of the "mtime" parameter of the perl "stat" function. - -=back - =head2 Cryptography =over 4 diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index 32abf1747..842e12f2a 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -296,7 +296,7 @@ foreach my $f (@files) # symlinks), this can't escape to delete anything it shouldn't # (unless someone moves the location of $webdotdir, of course) trick_taint($f); - my $mtime = file_mod_time($f); + my $mtime = (stat($f))[9]; if ($mtime && $mtime < $since) { unlink $f; } -- cgit v1.2.3-24-g4f1b