From 39633788a33cbe86b5ebc292fb18652fdc702e46 Mon Sep 17 00:00:00 2001 From: "kiko%async.com.br" <> Date: Thu, 29 Jul 2004 09:45:37 +0000 Subject: Fix for bug 236678: Clean up access to COOKIE global. Murder the last remaining places in the tree where COOKIE is used; includes a rather thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave. --- Bugzilla.pm | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'Bugzilla.pm') diff --git a/Bugzilla.pm b/Bugzilla.pm index 0818fb1d5..56a8d615c 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -87,13 +87,10 @@ sub logout_user_by_id { # hack that invalidates credentials for a single request sub logout_request { undef $_user; + # XXX clean this up eventually $::userid = 0; - # XXX clean these up eventually - delete $::COOKIE{"Bugzilla_login"}; - # NB - Can't delete from $cgi->cookie, so the logincookie data will - # remain there; it's only used in Bugzilla::Auth::CGI->logout anyway - # People shouldn't rely on the cookie param for the username - # - use Bugzilla->user instead! + # We can't delete from $cgi->cookie, so logincookie data will remain + # there. Don't rely on it: use Bugzilla->user->login instead! } my $_dbh; -- cgit v1.2.3-24-g4f1b