From 5ffe3d31dde3c11525ff09ce17e4b0d730e5e2fd Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Tue, 20 Jun 2006 14:39:01 +0000 Subject: Bug 278017: Eliminate use of deprecated Bugzilla::DB routines (SendSQL, etc.) - Patch by Frédéric Buclin r=mkanat a=myk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla.pm | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'Bugzilla.pm') diff --git a/Bugzilla.pm b/Bugzilla.pm index ea7740151..8c58454ed 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -315,17 +315,6 @@ sub _cleanup { undef $_cgi; undef $_user; - # See bug 192531. If we don't clear the possibly active statement handles, - # then when this is called from the END block, it happens _before_ the - # destructors in Bugzilla::DB have happened. - # See http://rt.perl.org/rt2/Ticket/Display.html?id=17450#38810 - # Without disconnecting explicitly here, noone notices, because DBI::END - # ends up calling DBD::mysql's $drh->disconnect_all, which is a noop. - # This code is evil, but it needs to be done, at least until SendSQL and - # friends can be removed - @Bugzilla::DB::SQLStateStack = (); - undef $Bugzilla::DB::_current_sth; - # When we support transactions, need to ->rollback here $_dbh_main->disconnect if $_dbh_main; $_dbh_shadow->disconnect if $_dbh_shadow && Bugzilla->params->{"shadowdb"}; -- cgit v1.2.3-24-g4f1b