From eb1357fe03bb47cdd479cf533022e11dd6bd22e0 Mon Sep 17 00:00:00 2001 From: Dylan Hardison Date: Tue, 22 Dec 2015 12:11:21 -0500 Subject: Bug 1230932 - Providing a condition as an ID to the webservice results in a taint error r=dkl,a=dkl --- Bugzilla/API/1_0/Util.pm | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) (limited to 'Bugzilla/API/1_0/Util.pm') diff --git a/Bugzilla/API/1_0/Util.pm b/Bugzilla/API/1_0/Util.pm index d22935f6e..3fcf28cdf 100644 --- a/Bugzilla/API/1_0/Util.pm +++ b/Bugzilla/API/1_0/Util.pm @@ -22,6 +22,7 @@ use MIME::Base64 qw(decode_base64 encode_base64); use Storable qw(dclone); use Test::Taint (); use URI::Escape qw(uri_unescape); +use Bugzilla::WebService::Util qw(validate); use parent qw(Exporter); @@ -241,28 +242,6 @@ sub api_include_exclude { return $params; } -sub validate { - my ($self, $params, @keys) = @_; - - # If $params is defined but not a reference, then we weren't - # sent any parameters at all, and we're getting @keys where - # $params should be. - return ($self, undef) if (defined $params and !ref $params); - - # If @keys is not empty then we convert any named - # parameters that have scalar values to arrayrefs - # that match. - foreach my $key (@keys) { - if (exists $params->{$key}) { - $params->{$key} = ref $params->{$key} - ? $params->{$key} - : [ $params->{$key} ]; - } - } - - return ($self, $params); -} - sub translate { my ($params, $mapped) = @_; my %changes; -- cgit v1.2.3-24-g4f1b