From a81a0804496d263f9de71b03e2ebf612e3c534cc Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Tue, 9 Oct 2007 18:05:58 +0000 Subject: Midair with product change while adding an attachment silently clears flags - Patch by Tiago R. Mello r/a=LpSolit --- Bugzilla/Attachment.pm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'Bugzilla/Attachment.pm') diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index 736959b2f..cc3e16893 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -484,7 +484,7 @@ sub _validate_data { my $imgdata = $img->ImageToBlob(); $data = $imgdata; $cgi->param('contenttype', 'image/png'); - $$hr_vars->{'convertedbmp'} = 1; + $hr_vars->{'convertedbmp'} = 1; } # Make sure the attachment does not exceed the maximum permitted size @@ -810,12 +810,12 @@ sub insert_attachment_for_bug { '^requestee(_type)?-(\d+)$' => { 'type' => 'multi' }, }, MATCH_SKIP_CONFIRM); - $$hr_vars->{'match_field'} = 'requestee'; + $hr_vars->{'match_field'} = 'requestee'; if ($match_status == USER_MATCH_FAILED) { - $$hr_vars->{'message'} = 'user_match_failed'; + $hr_vars->{'message'} = 'user_match_failed'; } elsif ($match_status == USER_MATCH_MULTIPLE) { - $$hr_vars->{'message'} = 'user_match_multiple'; + $hr_vars->{'message'} = 'user_match_multiple'; } # Escape characters in strings that will be used in SQL statements. @@ -902,12 +902,12 @@ sub insert_attachment_for_bug { Bugzilla->error_mode(ERROR_MODE_DIE); eval { Bugzilla::Flag::validate($cgi, $bug->bug_id, -1, SKIP_REQUESTEE_ON_ERROR); - Bugzilla::Flag::process($bug, $attachment, $timestamp, $cgi); + Bugzilla::Flag::process($bug, $attachment, $timestamp, $cgi, $hr_vars); }; Bugzilla->error_mode($error_mode_cache); if ($@) { - $$hr_vars->{'message'} = 'flag_creation_failed'; - $$hr_vars->{'flag_creation_error'} = $@; + $hr_vars->{'message'} = 'flag_creation_failed'; + $hr_vars->{'flag_creation_error'} = $@; } # Return the new attachment object. -- cgit v1.2.3-24-g4f1b