From 4d295ae996aa2b46dee2b66a3ba1270345cacd3d Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Thu, 7 Feb 2013 15:02:20 +0800 Subject: Bug 784352: show a warning when interdiff reports errors --- Bugzilla/Attachment/PatchReader.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'Bugzilla/Attachment') diff --git a/Bugzilla/Attachment/PatchReader.pm b/Bugzilla/Attachment/PatchReader.pm index 800de0722..b766a9071 100644 --- a/Bugzilla/Attachment/PatchReader.pm +++ b/Bugzilla/Attachment/PatchReader.pm @@ -122,7 +122,8 @@ sub process_interdiff { # Check for errors { local $/ = undef; - if (defined(my $error = <$interdiff_stderr>)) { + my $error = <$interdiff_stderr>; + if ($error) { warn($error); $warning = 'interdiff3'; } -- cgit v1.2.3-24-g4f1b