From 8d2b07ea05e895f040d1805221135bfb68dc7f7c Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Thu, 31 Dec 2009 12:53:19 +0000 Subject: Bug 527586: Use X-Forwarded-For instead of REMOTE_ADDR for trusted proxies Patch by Max Kanat-Alexander r=dkl, a=mkanat --- Bugzilla/Auth/Login/Cookie.pm | 2 +- Bugzilla/Auth/Persist/Cookie.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'Bugzilla/Auth') diff --git a/Bugzilla/Auth/Login/Cookie.pm b/Bugzilla/Auth/Login/Cookie.pm index 0b002168e..570988f7e 100644 --- a/Bugzilla/Auth/Login/Cookie.pm +++ b/Bugzilla/Auth/Login/Cookie.pm @@ -35,7 +35,7 @@ sub get_login_info { my $cgi = Bugzilla->cgi; my $dbh = Bugzilla->dbh; - my $ip_addr = $cgi->remote_addr(); + my $ip_addr = remote_ip(); my $login_cookie = $cgi->cookie("Bugzilla_logincookie"); my $user_id = $cgi->cookie("Bugzilla_login"); diff --git a/Bugzilla/Auth/Persist/Cookie.pm b/Bugzilla/Auth/Persist/Cookie.pm index 1e1b3a871..232212075 100644 --- a/Bugzilla/Auth/Persist/Cookie.pm +++ b/Bugzilla/Auth/Persist/Cookie.pm @@ -52,7 +52,7 @@ sub persist_login { my $ip_addr; if ($input_params->{'Bugzilla_restrictlogin'}) { - $ip_addr = $cgi->remote_addr; + $ip_addr = remote_ip(); # The IP address is valid, at least for comparing with itself in a # subsequent login trick_taint($ip_addr); -- cgit v1.2.3-24-g4f1b