From 23ac1fef4768e1d162e8a99cf599684e4cecdc1f Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Tue, 7 Jul 2009 11:08:19 +0000 Subject: Bug 502682: CheckIfVotedConfirmed fails to confirm a bug if you don't have the permissions to set status/everconfirmed - Patch by Frédéric Buclin r/a=mkanat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Bug.pm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'Bugzilla/Bug.pm') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index a2db3572a..dbb88be6a 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -3373,11 +3373,17 @@ sub CheckIfVotedConfirmed { } ThrowCodeError('no_open_bug_status') unless $new_status; - $bug->set_status($new_status); + # We cannot call $bug->set_status() here, because a user without + # canconfirm privs should still be able to confirm a bug by + # popular vote. We already know the new status is valid, so it's safe. + $bug->{bug_status} = $new_status; + $bug->{everconfirmed} = 1; + delete $bug->{'status'}; # Contains the status object. } else { # If the bug is in a closed state, only set everconfirmed to 1. - $bug->_set_everconfirmed(1); + # Do not call $bug->_set_everconfirmed(), for the same reason as above. + $bug->{everconfirmed} = 1; } $bug->update(); -- cgit v1.2.3-24-g4f1b