From 3a92f2d18482834d9f51852c3809b687452fea0e Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Wed, 9 Mar 2005 07:03:57 +0000 Subject: Bug 283919: Move BugAliasToID out of CGI.pl into Bugzilla::Bug Patch By Max Kanat-Alexander r=LpSolit, a=myk --- Bugzilla/Bug.pm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'Bugzilla/Bug.pm') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index b9229d98e..501f707b0 100755 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -46,6 +46,7 @@ use Bugzilla::Error; use base qw(Exporter); @Bugzilla::Bug::EXPORT = qw( + bug_alias_to_id ValidateComment ); @@ -123,7 +124,7 @@ sub initBug { my $old_bug_id = $bug_id; # If the bug ID isn't numeric, it might be an alias, so try to convert it. - $bug_id = &::BugAliasToID($bug_id) if $bug_id !~ /^0*[1-9][0-9]*$/; + $bug_id = bug_alias_to_id($bug_id) if $bug_id !~ /^0*[1-9][0-9]*$/; if ((! defined $bug_id) || (!$bug_id) || (!detaint_natural($bug_id))) { # no bug number given or the alias didn't match a bug @@ -496,6 +497,20 @@ sub choices { return $self->{'choices'}; } +# Convenience Function. If you need speed, use this. If you need +# other Bug fields in addition to this, just create a new Bug with +# the alias. +# Queries the database for the bug with a given alias, and returns +# the ID of the bug if it exists or the undefined value if it doesn't. +sub bug_alias_to_id ($) { + my ($alias) = @_; + return undef unless Param("usebugaliases"); + my $dbh = Bugzilla->dbh; + trick_taint($alias); + return $dbh->selectrow_array( + "SELECT bug_id FROM bugs WHERE alias = ?", undef, $alias); +} + sub EmitDependList { my ($myfield, $targetfield, $bug_id) = (@_); my $dbh = Bugzilla->dbh; -- cgit v1.2.3-24-g4f1b