From 5ab9af110e4bb7fc406b2cdcf97fd22cb265b592 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 14 Oct 2013 14:44:24 +0200 Subject: Backout 1st part of bug 340160: state $sth doesn't work fine with mod_perl --- Bugzilla/Bug.pm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'Bugzilla/Bug.pm') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 2c0d458e7..61731c039 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -3954,11 +3954,7 @@ sub get_activity { # Update the bugs_activity table to reflect changes made in bugs. sub LogActivityEntry { my ($i, $col, $removed, $added, $whoid, $timestamp, $comment_id) = @_; - state $sth = - Bugzilla->dbh->prepare('INSERT INTO bugs_activity - (bug_id, who, bug_when, fieldid, removed, added, comment_id) - VALUES (?, ?, ?, ?, ?, ?, ?)'); - + my $dbh = Bugzilla->dbh; # in the case of CCs, deps, and keywords, there's a possibility that someone # might try to add or remove a lot of them at once, which might take more # space than the activity table allows. We'll solve this by splitting it @@ -3982,7 +3978,10 @@ sub LogActivityEntry { trick_taint($addstr); trick_taint($removestr); my $fieldid = get_field_id($col); - $sth->execute($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id); + $dbh->do("INSERT INTO bugs_activity + (bug_id, who, bug_when, fieldid, removed, added, comment_id) + VALUES (?, ?, ?, ?, ?, ?, ?)", + undef, ($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id)); } } -- cgit v1.2.3-24-g4f1b