From 8ef93208df4b0c83acb4d24772b7af062d36ec78 Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Sat, 2 Jul 2005 12:23:27 +0000 Subject: Bug 289042: Implicit joins should be replaced by explicit joins - installment B Patch By Max Kanat-Alexander r=LpSolit, r=joel, a=justdave --- Bugzilla/Bug.pm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) (limited to 'Bugzilla/Bug.pm') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 39864d252..675c2ec15 100755 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -163,12 +163,16 @@ sub initBug { reporter_accessible, cclist_accessible, estimated_time, remaining_time, " . $dbh->sql_date_format('deadline', '%Y-%m-%d') . " - FROM bugs LEFT JOIN votes using(bug_id), - classifications, products, components - WHERE bugs.bug_id = ? - AND classifications.id = products.classification_id - AND products.id = bugs.product_id - AND components.id = bugs.component_id " . + FROM bugs + LEFT JOIN votes + USING (bug_id) + INNER JOIN components + ON components.id = bugs.component_id + INNER JOIN products + ON products.id = bugs.product_id + INNER JOIN classifications + ON classifications.id = products.classification_id + WHERE bugs.bug_id = ? " . $dbh->sql_group_by('bugs.bug_id', 'alias, products.classification_id, classifications.name, bugs.product_id, products.name, version, rep_platform, op_sys, bug_status, resolution, priority, -- cgit v1.2.3-24-g4f1b