From 8f33041e6542f12e6897ef6ed7a67c43a118c504 Mon Sep 17 00:00:00 2001
From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Wed, 23 Jun 2010 17:39:11 -0700
Subject: Bug 572602: Change the way that Bugzilla::Object determines what
 fields are required for create(). It now assumes that any column that is NOT
 NULL and has not DEFAULT in the database is required. We also shift the
 burden of throwing errors about empty values to the validators. This fixes
 the bug that Bugzilla::Bug->create() wasn't populating default values for
 fields if they weren't specified in the create() parameters. r=timello,
 a=mkanat

---
 Bugzilla/Bug.pm | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

(limited to 'Bugzilla/Bug.pm')

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 614d83a64..58901c57e 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -115,15 +115,6 @@ sub DB_COLUMNS {
     return @columns;
 }
 
-use constant REQUIRED_CREATE_FIELDS => qw(
-    component
-    product
-    short_desc
-    version
-);
-
-# There are also other, more complex validators that are called
-# from run_create_validators.
 sub VALIDATORS {
 
     my $validators = {
@@ -290,6 +281,11 @@ use constant FIELD_MAP => {
     offset           => 'OFFSET',
 };
 
+use constant REQUIRED_FIELD_MAP => {
+    product_id   => 'product',
+    component_id => 'component',
+};
+
 #####################################################################
 
 sub new {
@@ -1696,8 +1692,8 @@ sub _check_reporter {
     else {
         # On bug creation, the reporter is the logged in user
         # (meaning that he must be logged in first!).
+        Bugzilla->login(LOGIN_REQUIRED);
         $reporter = Bugzilla->user->id;
-        $reporter || ThrowCodeError('invalid_user');
     }
     return $reporter;
 }
-- 
cgit v1.2.3-24-g4f1b