From 9f5ecaad75e76200f8c304083a3244eecf801dff Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Tue, 19 Dec 2006 16:38:49 +0000 Subject: Bug 364286: Code in Classification->products() is suboptimal - Patch by Frédéric Buclin r=mkanat a=justdave MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Classification.pm | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'Bugzilla/Classification.pm') diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm index 3d264b704..37ae3a0cc 100644 --- a/Bugzilla/Classification.pm +++ b/Bugzilla/Classification.pm @@ -106,12 +106,8 @@ sub products { SELECT id FROM products WHERE classification_id = ? ORDER BY name}, undef, $self->id); - - my @products; - foreach my $product_id (@$product_ids) { - push (@products, new Bugzilla::Product($product_id)); - } - $self->{'products'} = \@products; + + $self->{'products'} = Bugzilla::Product->new_from_list($product_ids); } return $self->{'products'}; } -- cgit v1.2.3-24-g4f1b