From ef925d6942a3462a9c1d52406a6145b5e31faefb Mon Sep 17 00:00:00 2001
From: Frédéric Buclin <LpSolit@gmail.com>
Date: Mon, 24 Feb 2014 18:14:08 +0100
Subject: Bug 975896: Bugzilla crashes when editing a flag type which is not
 specifically requestable r/a=glob

---
 Bugzilla/Classification.pm | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

(limited to 'Bugzilla/Classification.pm')

diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm
index 5d488e3b9..6e88bdc63 100644
--- a/Bugzilla/Classification.pm
+++ b/Bugzilla/Classification.pm
@@ -48,6 +48,7 @@ use constant VALIDATORS => {
 ###############################
 ####     Constructors     #####
 ###############################
+
 sub remove_from_db {
     my $self = shift;
     my $dbh = Bugzilla->dbh;
@@ -57,13 +58,13 @@ sub remove_from_db {
     $dbh->bz_start_transaction();
 
     # Reclassify products to the default classification, if needed.
-    my @product_ids = $dbh->selectrow_array(
-        "SELECT id FROM products WHERE classification_id = ?",
-        undef, $self->id);
-    if (@product_ids) {
-        $dbh->do("UPDATE products SET classification_id = 1 WHERE " .
-            $dbh->sql_in('id', \@product_ids));
-        foreach my $id (@product_ids) {
+    my $product_ids = $dbh->selectcol_arrayref(
+        'SELECT id FROM products WHERE classification_id = ?', undef, $self->id);
+
+    if (@$product_ids) {
+        $dbh->do('UPDATE products SET classification_id = 1 WHERE '
+                  . $dbh->sql_in('id', $product_ids));
+        foreach my $id (@$product_ids) {
             Bugzilla->memcached->clear({ table => 'products', id => $id });
         }
     }
-- 
cgit v1.2.3-24-g4f1b