From d165b7785df760352ce17d3677691c5be0b3b6c4 Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Fri, 1 Aug 2008 05:14:43 +0000 Subject: Bug 448241: [Oracle] Foreign keys: UPDATE CASCADE trigger updates wrong tables and fields Patch By Xiaoou Wu r=mkanat, a=mkanat --- Bugzilla/DB/Schema/Oracle.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'Bugzilla/DB/Schema') diff --git a/Bugzilla/DB/Schema/Oracle.pm b/Bugzilla/DB/Schema/Oracle.pm index 05c2bbeb3..ba3870a76 100644 --- a/Bugzilla/DB/Schema/Oracle.pm +++ b/Bugzilla/DB/Schema/Oracle.pm @@ -153,15 +153,15 @@ sub get_fk_ddl { if ( $update =~ /CASCADE/i ){ my $tr_str = "CREATE OR REPLACE TRIGGER ${fk_name}_UC" - . " AFTER UPDATE ON ". $table + . " AFTER UPDATE ON ". $to_table . " REFERENCING " . " NEW AS NEW " . " OLD AS OLD " . " FOR EACH ROW " . " BEGIN " - . " UPDATE $to_table" - . " SET $to_column = :NEW.$column" - . " WHERE $to_column = :OLD.$column;" + . " UPDATE $table" + . " SET $column = :NEW.$to_column" + . " WHERE $column = :OLD.$to_column;" . " END ${fk_name}_UC;"; my $dbh = Bugzilla->dbh; $dbh->do($tr_str); -- cgit v1.2.3-24-g4f1b