From db8c5141a90a910dca5600ba094b6f7d04b749bf Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Fri, 23 Jan 2015 12:07:34 +0100 Subject: Bug 493027: Update the comment in DB::Pg::sql_string_concat() r=gerv a=glob --- Bugzilla/DB/Pg.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'Bugzilla/DB') diff --git a/Bugzilla/DB/Pg.pm b/Bugzilla/DB/Pg.pm index 4ec95725d..59231e2a6 100644 --- a/Bugzilla/DB/Pg.pm +++ b/Bugzilla/DB/Pg.pm @@ -187,10 +187,9 @@ sub sql_date_math { sub sql_string_concat { my ($self, @params) = @_; - - # Postgres 7.3 does not support concatenating of different types, so we - # need to cast both parameters to text. Version 7.4 seems to handle this - # properly, so when we stop support 7.3, this can be removed. + + # PostgreSQL 8.3 and newer require an explicit coercion to text + # to support concatenation of different data types. return '(CAST(' . join(' AS text) || CAST(', @params) . ' AS text))'; } -- cgit v1.2.3-24-g4f1b