From 8bc37c2d851e06b036c8f895582fedd7051b3592 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Fri, 14 May 2010 07:11:38 -0700 Subject: Bug 372537: Improve CodeErrors: show the traceback (without function arguments) r=LpSolit, a=LpSolit --- Bugzilla/Error.pm | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'Bugzilla/Error.pm') diff --git a/Bugzilla/Error.pm b/Bugzilla/Error.pm index 0c471125d..60e7837de 100644 --- a/Bugzilla/Error.pm +++ b/Bugzilla/Error.pm @@ -31,6 +31,8 @@ use base qw(Exporter); use Bugzilla::Constants; use Bugzilla::WebService::Constants; use Bugzilla::Util; + +use Carp; use Date::Format; # We cannot use $^S to detect if we are in an eval(), because mod_perl @@ -50,6 +52,12 @@ sub _throw_error { $vars ||= {}; $vars->{error} = $error; + # Don't show function arguments, in case they contain confidential data. + local $Carp::MaxArgNums = -1; + # Don't show the error as coming from Bugzilla::Error, show it as coming + # from the caller. + local $Carp::CarpInternal{'Bugzilla::Error'} = 1; + $vars->{traceback} = Carp::longmess(); # Make sure any transaction is rolled back (if supported). # If we are within an eval(), do not roll back transactions as we are -- cgit v1.2.3-24-g4f1b