From a1d2460f8c48c8f23d1fc2ed876ec65cfd370949 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Thu, 23 Jul 2009 21:33:54 +0000 Subject: Bug 504944: Use of uninitialized value in hash element at Bugzilla/Field/Choice.pm line 253 - Patch by Frédéric Buclin r/a=mkanat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Field/Choice.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'Bugzilla/Field') diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm index ce1020d6b..7e07ca1e2 100644 --- a/Bugzilla/Field/Choice.pm +++ b/Bugzilla/Field/Choice.pm @@ -250,10 +250,11 @@ sub field { sub is_default { my $self = shift; - my $param_value = - Bugzilla->params->{ $self->DEFAULT_MAP->{$self->field->name} }; - return 0 if !defined $param_value; - return $self->name eq $param_value ? 1 : 0; + my $name = $self->DEFAULT_MAP->{$self->field->name}; + # If it doesn't exist in DEFAULT_MAP, then there is no parameter + # related to this field. + return 0 unless $name; + return ($self->name eq Bugzilla->params->{$name}) ? 1 : 0; } sub is_static { -- cgit v1.2.3-24-g4f1b